lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Otis Gospodnetic (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-667) javacc skeleton files not regenerated
Date Fri, 20 Oct 2006 16:15:38 GMT
    [ http://issues.apache.org/jira/browse/LUCENE-667?page=comments#action_12443881 ] 
            
Otis Gospodnetic commented on LUCENE-667:
-----------------------------------------

I'm okay with this, although this might one day piss somebody off - imagine making manual
changes, running the javacc task, and losing your changes.  Ouch.

Perhaps you should add some <echo> and some <sleep> before removing files, to
give the person a chance to cancel this.

> javacc skeleton files not regenerated
> -------------------------------------
>
>                 Key: LUCENE-667
>                 URL: http://issues.apache.org/jira/browse/LUCENE-667
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: QueryParser
>            Reporter: Steven Parkes
>         Assigned To: Steven Parkes
>            Priority: Minor
>             Fix For: 2.1
>
>         Attachments: javacc.patch
>
>
> Copies of the the character stream files for javacc are checked into svn. These files
were generated under javacc 3.0 (at least that's what they say, though javacc 3.2 says this
too). javacc 4 complains that they are out of date but won't replace them; they must be removed
before it will regenerate them.
> There is one side effect of removing them: local changes are lost.  r387550 removed a
couple of deprecated methods. By using the files as generated by javacc, these deprecated
 methods will be readded (at least until the javacc team removes them totally). There are
other changes being made to the stream files, so I woudl think it's better to live with them
unmodified than to keep local versions just for this change.
> If we want javacc to recreate the files, the attached patch will remove them before running
javacc.
> All the tests pass using both javacc3.2 and 4.0.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message