lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Nicolas Lalevée <nicolas.lale...@anyware-tech.com>
Subject Re: LazyField retains temp char[] buffer
Date Sun, 08 Oct 2006 10:46:47 GMT
Le Samedi 07 Octobre 2006 18:29, Yonik Seeley a écrit :
> While reviewing some of the LazyField code in preparation for Solr support,
> https://issues.apache.org/jira/browse/SOLR-52
> I noticed that the char[] used to read the String data is a member,
> and thus kept around after the data is read and a String constructed.
> It doesn't look like it serves any purpose... I assume this is just a
> little oversight?

It looks like to me that this was designed to avoid many instanciation of 
char[] buffers. So I wouldssay that this would be static, but then you will 
certainly have concurrency problems.

Maybe you can be interested in the way I worked with it in LUCENE-662.

Nicolas

---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message