Return-Path: Delivered-To: apmail-lucene-java-dev-archive@www.apache.org Received: (qmail 21867 invoked from network); 16 Sep 2006 03:51:43 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 16 Sep 2006 03:51:43 -0000 Received: (qmail 67715 invoked by uid 500); 16 Sep 2006 03:51:40 -0000 Delivered-To: apmail-lucene-java-dev-archive@lucene.apache.org Received: (qmail 67685 invoked by uid 500); 16 Sep 2006 03:51:40 -0000 Mailing-List: contact java-dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: java-dev@lucene.apache.org Delivered-To: mailing list java-dev@lucene.apache.org Received: (qmail 67674 invoked by uid 99); 16 Sep 2006 03:51:40 -0000 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received: from [209.237.227.198] (HELO brutus.apache.org) (209.237.227.198) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 15 Sep 2006 20:51:40 -0700 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 5685171434D for ; Sat, 16 Sep 2006 03:47:23 +0000 (GMT) Message-ID: <1551239.1158378443351.JavaMail.jira@brutus> Date: Fri, 15 Sep 2006 20:47:23 -0700 (PDT) From: "Ning Li (JIRA)" To: java-dev@lucene.apache.org Subject: [jira] Commented: (LUCENE-672) new merge policy In-Reply-To: <12139165.1158256583097.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N [ http://issues.apache.org/jira/browse/LUCENE-672?page=comments#action_12435174 ] Ning Li commented on LUCENE-672: -------------------------------- A small fix named KeepDocCount0Segment.Sept15.patch is attached to LUCENE-565 (can't attach here). In mergeSegments(...), if the doc count of a merged segment is 0, it is not added to the index (it should be properly cleaned up). Before LUCENE-672, a merged segment was always added to the index. The use of mergeSegments(...) in, e.g. addIndexes(Directory[]), assumed that behaviour. For code simplicity, this fix restores the old behaviour that a merged segment is always added to the index. This does NOT break any of the good properties of the new merge policy. TestIndexWriterMergePolicy is slightly modified to fix a bug and to check that segments are probably cleaned up. The patch passes all the tests. > new merge policy > ---------------- > > Key: LUCENE-672 > URL: http://issues.apache.org/jira/browse/LUCENE-672 > Project: Lucene - Java > Issue Type: New Feature > Components: Index > Affects Versions: 2.0.0 > Reporter: Yonik Seeley > Assigned To: Yonik Seeley > Fix For: 2.1 > > > New merge policy developed in the course of > http://issues.apache.org/jira/browse/LUCENE-565 > http://issues.apache.org/jira/secure/attachment/12340475/newMergePolicy.Sept08.patch -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org For additional commands, e-mail: java-dev-help@lucene.apache.org