lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From eks dev <>
Subject Re: [jira] Commented: (LUCENE-584) Decouple Filter from BitSet
Date Mon, 04 Sep 2006 10:56:28 GMT
any reason to have BitSetItrator method 
int next(int fromIndex) {...
package protected 

Would be interesing to see how BitSetIterator works in Matcher, skipping is needed there

----- Original Message ----
From: paul.elschot (JIRA) <>
Sent: Monday, 4 September, 2006 8:47:24 AM
Subject: [jira] Commented: (LUCENE-584) Decouple Filter from BitSet

    [ ] 
paul.elschot commented on LUCENE-584:

> No performance changes as well.

It's good to hear that. As mentioned earlier, this is groundwork only.
Once an actual Matcher is used I expect some some performance differences to show up.

Which comment of Yonik related to HitCollector do you mean?

> Early this week we will try to implement our first Matchers and see how they behave 

BitsMatcher and SortedVIntList could start that.
Also I'd like to see one on Solr's OpenBitSet...

> Decouple Filter from BitSet
> ---------------------------
>                 Key: LUCENE-584
>                 URL:
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Search
>    Affects Versions: 2.0.1
>            Reporter: Peter Schäfer
>            Priority: Minor
>         Attachments:, Filter-20060628.patch, HitCollector-20060628.patch,
IndexSearcher-20060628.patch,,, Matcher20060830b.patch, Scorer-20060628.patch,
Searchable-20060628.patch, Searcher-20060628.patch,,
> {code}
> package;
> public abstract class Filter implements 
> {
>   public abstract AbstractBitSet bits(IndexReader reader) throws IOException;
> }
> public interface AbstractBitSet 
> {
>   public boolean get(int index);
> }
> {code}
> It would be useful if the method =Filter.bits()= returned an abstract interface, instead
of =java.util.BitSet=.
> Use case: there is a very large index, and, depending on the user's privileges, only
a small portion of the index is actually visible.
> Sparsely populated =java.util.BitSet=s are not efficient and waste lots of memory. It
would be desirable to have an alternative BitSet implementation with smaller memory footprint.
> Though it _is_ possibly to derive classes from =java.util.BitSet=, it was obviously not
designed for that purpose.
> That's why I propose to use an interface instead. The default implementation could still
delegate to =java.util.BitSet=.

This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
For more information on JIRA, see:

To unsubscribe, e-mail:
For additional commands, e-mail:

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message