lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chris Hostetter <>
Subject Re: [jira] Commented: (LUCENE-623) RAMDirectory.close() should have a comment about not releasing any resources
Date Mon, 10 Jul 2006 07:27:32 GMT

: I should metion that there is an upside to the patch.... it can
: uncover bugs by detecting access after a close().  Before, this would
: have worked with a RAMDirectory, but failed with a FSDirectory.

yeah, seeing that test failure when i made the change locally is what sold
me on commiting it -- that and it seemed to demonstrate the principle of
least suprise, the dir.close() releases the resources it has -- which may
not truely do anything at run time, but someone reading the code won't
scratch there head.

i didn't realize that it can potentially hurt performance as yonik
mentioned (frankly: i still don't understand how that can be the case, but
when yonik makes a statement about performance: i believe him.)

Is this serious enough to revert?


To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message