lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mark Harwood (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-627) highlighter problems with overlapping tokens
Date Sat, 15 Jul 2006 20:52:14 GMT
    [ http://issues.apache.org/jira/browse/LUCENE-627?page=comments#action_12421342 ] 
            
Mark Harwood commented on LUCENE-627:
-------------------------------------

Hi Yonik,
Been away for a little while and just managed to catch up with your changes. Thanks for this.

Looking at the patch all seems good. I would just change a couple of things:

1) TokenGroup.getTotalScore should just return your new "tot" variable
2) TokenGroup.clear() needs to reinitialize "tot" to zero.


Other than that all looks good to me. Let me know if you're happy and I'll commit it.

Thanks again

> highlighter problems with overlapping tokens
> --------------------------------------------
>
>                 Key: LUCENE-627
>                 URL: http://issues.apache.org/jira/browse/LUCENE-627
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: Other
>    Affects Versions: 2.0.1
>            Reporter: Yonik Seeley
>         Attachments: highlight_overlap.diff
>
>
> The lucene highlighter has problems when tokens that overlap are generated.
> For example, if analysis of iPod generates the tokens "i", "pod", "ipod" (with pod and
ipod in the same position),
> then the highlighter will output this as iipod, regardless of if any of those tokens
are highlighted.
> Discovered via http://issues.apache.org/jira/browse/SOLR-24

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message