Return-Path: Delivered-To: apmail-lucene-java-dev-archive@www.apache.org Received: (qmail 48994 invoked from network); 19 Jun 2006 20:18:12 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 19 Jun 2006 20:18:12 -0000 Received: (qmail 47376 invoked by uid 500); 19 Jun 2006 20:18:08 -0000 Delivered-To: apmail-lucene-java-dev-archive@lucene.apache.org Received: (qmail 47315 invoked by uid 500); 19 Jun 2006 20:18:08 -0000 Mailing-List: contact java-dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: java-dev@lucene.apache.org Delivered-To: mailing list java-dev@lucene.apache.org Received: (qmail 47110 invoked by uid 99); 19 Jun 2006 20:18:02 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 19 Jun 2006 13:18:02 -0700 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received-SPF: neutral (asf.osuosl.org: local policy) Received: from [169.229.70.167] (HELO rescomp.berkeley.edu) (169.229.70.167) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 19 Jun 2006 13:18:02 -0700 Received: by rescomp.berkeley.edu (Postfix, from userid 1007) id 53DB85B766; Mon, 19 Jun 2006 13:17:37 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by rescomp.berkeley.edu (Postfix) with ESMTP id 483D97F403 for ; Mon, 19 Jun 2006 13:17:37 -0700 (PDT) Date: Mon, 19 Jun 2006 13:17:37 -0700 (PDT) From: Chris Hostetter To: java-dev@lucene.apache.org Subject: Re: Seeking feedback on LUCENE-557 In-Reply-To: <200606192134.58104.paul.elschot@xs4all.nl> Message-ID: References: <4496F5F5.4000604@syr.edu> <200606192134.58104.paul.elschot@xs4all.nl> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N : > > Should This HACK be commited, or is it better to leave explanations for : > > SpanNear queries broken untill someone has the confidence to fix LUCENE-569? : > I think it would be all right as long as you make a note of it on the : > 569 issue and in the code so that people know why the change is in there. : I'll try and make the change to NearSpansOrdered indicated here: : http://issues.apache.org/jira/browse/LUCENE-569#action_12411904 : in a week or so to avoid the need for hacks and comments to jira issues : in the code. yeah ... I think i'll move forward with commiting just the CheckHits additions, the BooleanQuery and FilteredQuery fixes, as well as all of the new test cases that pass. I'll attach the explain test patches that rely on NearSpans.skipTo to LUCENE-569, and all of the remaining new tests that require a "match" boolean to LUCENE-605 -Hoss --------------------------------------------------------------------- To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org For additional commands, e-mail: java-dev-help@lucene.apache.org