Mailing-List: contact java-dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
Reply-To: java-dev@lucene.apache.org
Received-SPF: pass (asf.osuosl.org: local policy)
Message-ID: <4496F5F5.4000604@syr.edu>
Date: Mon, 19 Jun 2006 15:07:33 -0400
From: Grant Ingersoll <gsingers@syr.edu>
User-Agent: Thunderbird 1.5.0.4 (Windows/20060516)
MIME-Version: 1.0
To: java-dev@lucene.apache.org
Subject: Re: Seeking feedback on LUCENE-557
References: <Pine.LNX.4.58.0606151505100.11094@hal.rescomp.berkeley.edu>
In-Reply-To: <Pine.LNX.4.58.0606151505100.11094@hal.rescomp.berkeley.edu>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit


Chris Hostetter wrote:
> 2) SpanScorer.explain HACK fix
>
> NearSpans.skipTo is broken (see LUCENE-569).  This apparently doesn't
> affect too many people (or if it does, they haven't been filing bugs about
> it)  but it does make SpanScorer.explain lie.  I don't understand
> SpanQueries enough to feel comfortable fixing LUCENE-569 (even though
> paul.elschot has pointed out an alternate version of NearSpans that
> doesn't have this bug) but I do have a HACK patch for SpanScorer.explain
> that works arround the bug by just looping over NearSpans.next instead of
> using NearSpans.skipTo.
>
> Should This HACK be commited, or is it better to leave explanations for
> SpanNear queries broken untill someone has the confidence to fix LUCENE-569?
>
>   
I think it would be all right as long as you make a note of it on the 
569 issue and in the code so that people know why the change is in there.

-Grant

---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org