Return-Path: Delivered-To: apmail-lucene-java-dev-archive@www.apache.org Received: (qmail 13178 invoked from network); 30 Jun 2006 13:02:15 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 30 Jun 2006 13:02:15 -0000 Received: (qmail 92766 invoked by uid 500); 30 Jun 2006 13:02:12 -0000 Delivered-To: apmail-lucene-java-dev-archive@lucene.apache.org Received: (qmail 92690 invoked by uid 500); 30 Jun 2006 13:02:12 -0000 Mailing-List: contact java-dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: java-dev@lucene.apache.org Delivered-To: mailing list java-dev@lucene.apache.org Received: (qmail 92668 invoked by uid 99); 30 Jun 2006 13:02:11 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 30 Jun 2006 06:02:11 -0700 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received: from [209.237.227.198] (HELO brutus.apache.org) (209.237.227.198) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 30 Jun 2006 06:02:10 -0700 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 5ED1241033B for ; Fri, 30 Jun 2006 13:00:31 +0000 (GMT) Message-ID: <2489662.1151672431385.JavaMail.jira@brutus> Date: Fri, 30 Jun 2006 13:00:31 +0000 (GMT+00:00) From: "Michael McCandless (JIRA)" To: java-dev@lucene.apache.org Subject: [jira] Updated: (LUCENE-621) Default lock timeouts should have static setter/getters In-Reply-To: <13267927.1151672430142.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N [ http://issues.apache.org/jira/browse/LUCENE-621?page=all ] Michael McCandless updated LUCENE-621: -------------------------------------- Attachment: IndexWriter.java.diff Small changes to IndexWriter.java to add default (static) getter/setters for COMMIT_LOCK_TIMEOUT and WRITE_LOCK_TIMEOUT. > Default lock timeouts should have static setter/getters > ------------------------------------------------------- > > Key: LUCENE-621 > URL: http://issues.apache.org/jira/browse/LUCENE-621 > Project: Lucene - Java > Type: Bug > Components: Index > Versions: 2.0.0 > Reporter: Michael McCandless > Priority: Minor > Attachments: IndexWriter.java.diff > > We recently stopped using Java system properties to derive defaults for things like the write/commit lock timeout, and switched to getter/setter's across all classes. See here: > http://www.gossamer-threads.com/lists/lucene/java-dev/27447 > But, in the case at least of the write lock timeout, because it's marked "public final static", a consumer of this API can no longer change this value before instantiating the IndexWriter. This is because the getter/setter for this is not static, which generally makes sense so you can change the timeout for each instance of IndexWriter. But because IndexWriter on construction uses the timeout value, some uses cases need to change the value before getting an instance of IndexWriter. > This was actually a regression, in that Lucene users lost functionality they previously had, on upgrading. > I would propose that that we add getter/setter for the default value of this timeout, which would be static. I'll attach a patch file. > See this thread for context that led to this issue: > http://www.gossamer-threads.com/lists/lucene/java-dev/37421 -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org For additional commands, e-mail: java-dev-help@lucene.apache.org