Return-Path: Delivered-To: apmail-lucene-java-dev-archive@www.apache.org Received: (qmail 42919 invoked from network); 10 Jun 2006 04:10:39 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 10 Jun 2006 04:10:39 -0000 Received: (qmail 52199 invoked by uid 500); 10 Jun 2006 04:10:37 -0000 Delivered-To: apmail-lucene-java-dev-archive@lucene.apache.org Received: (qmail 52167 invoked by uid 500); 10 Jun 2006 04:10:37 -0000 Mailing-List: contact java-dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: java-dev@lucene.apache.org Delivered-To: mailing list java-dev@lucene.apache.org Received: (qmail 52156 invoked by uid 99); 10 Jun 2006 04:10:36 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 09 Jun 2006 21:10:36 -0700 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received: from [209.237.227.198] (HELO brutus.apache.org) (209.237.227.198) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 09 Jun 2006 21:10:36 -0700 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 32F827141EF for ; Sat, 10 Jun 2006 04:09:30 +0000 (GMT) Message-ID: <187580.1149912570199.JavaMail.jira@brutus> Date: Sat, 10 Jun 2006 04:09:30 +0000 (GMT+00:00) From: "Otis Gospodnetic (JIRA)" To: java-dev@lucene.apache.org Subject: [jira] Resolved: (LUCENE-594) Javadoc - Field constructor with Reader needs comment about retained reference In-Reply-To: <19025459.1149841710605.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N [ http://issues.apache.org/jira/browse/LUCENE-594?page=all ] Otis Gospodnetic resolved LUCENE-594: ------------------------------------- Resolution: Fixed I already did this yesterday, I believe. Thanks! > Javadoc - Field constructor with Reader needs comment about retained reference > ------------------------------------------------------------------------------ > > Key: LUCENE-594 > URL: http://issues.apache.org/jira/browse/LUCENE-594 > Project: Lucene - Java > Type: Improvement > Components: Index > Versions: 2.0.0 > Reporter: Rob Staveley (Tom) > Priority: Minor > > If you don't dig into the Lucene internals, it isn't obvious the Field constructor http://lucene.apache.org/java/docs/api/org/apache/lucene/document/Field.html#Field%28java.lang.String,%20java.io.Reader%29 retains a reference to the reader for use later on. It would be useful to have a comment added to the Javadoc saying something like: > Note: A reference to java.io.Reader is retained by the field. Reader is read from when the Document which this field is added to is itself added to the index. > Without this, the caller is liable to do silly things like closing the stream after constructing the org.apache.lucene.document.Field. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org For additional commands, e-mail: java-dev-help@lucene.apache.org