lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Grant Ingersoll <gsing...@syr.edu>
Subject Re: Seeking feedback on LUCENE-557
Date Mon, 19 Jun 2006 19:07:33 GMT


Chris Hostetter wrote:
> 2) SpanScorer.explain HACK fix
>
> NearSpans.skipTo is broken (see LUCENE-569).  This apparently doesn't
> affect too many people (or if it does, they haven't been filing bugs about
> it)  but it does make SpanScorer.explain lie.  I don't understand
> SpanQueries enough to feel comfortable fixing LUCENE-569 (even though
> paul.elschot has pointed out an alternate version of NearSpans that
> doesn't have this bug) but I do have a HACK patch for SpanScorer.explain
> that works arround the bug by just looping over NearSpans.next instead of
> using NearSpans.skipTo.
>
> Should This HACK be commited, or is it better to leave explanations for
> SpanNear queries broken untill someone has the confidence to fix LUCENE-569?
>
>   
I think it would be all right as long as you make a note of it on the 
569 issue and in the code so that people know why the change is in there.

-Grant

---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message