lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hoss Man (JIRA)" <j...@apache.org>
Subject [jira] Resolved: (LUCENE-572) SpanNotQuery.hashCode ignores exclude
Date Thu, 18 May 2006 08:00:06 GMT
     [ http://issues.apache.org/jira/browse/LUCENE-572?page=all ]
     
Hoss Man resolved LUCENE-572:
-----------------------------

    Resolution: Fixed

simple one line fix commited...

Index: src/java/org/apache/lucene/search/spans/SpanNotQuery.java
===================================================================
--- src/java/org/apache/lucene/search/spans/SpanNotQuery.java   (revision 407485)
+++ src/java/org/apache/lucene/search/spans/SpanNotQuery.java   (working copy)
@@ -172,7 +172,7 @@
   public int hashCode() {
     int h = include.hashCode();
     h = (h<<1) | (h >>> 31);  // rotate left
-    h ^= include.hashCode();
+    h ^= exclude.hashCode();
     h = (h<<1) | (h >>> 31);  // rotate left
     h ^= Float.floatToRawIntBits(getBoost());
     return h;


> SpanNotQuery.hashCode ignores exclude
> -------------------------------------
>
>          Key: LUCENE-572
>          URL: http://issues.apache.org/jira/browse/LUCENE-572
>      Project: Lucene - Java
>         Type: Bug

>   Components: Search
>     Reporter: Hoss Man
>     Assignee: Hoss Man
>     Priority: Minor
>      Fix For: 2.0

>
> filing as bug for tracking/refrence...
> On May 16, 2006, at 3:33 AM, Chris Hostetter wrote:
> > SpanNodeQuery's hashCode method makes two refrences to  
> > include.hashCode(),
> > but none to exclude.hashCode() ... this is a mistake yes/no?
> Date: Tue, 16 May 2006 05:57:15 -0400
> From: Erik Hatcher
> To: java-dev@lucene.apache.org
> Subject: Re: SpanNotQuery.hashCode cut/paste error?
> Yes, this is a mistake.  I'm happy to fix it, but looks like you have  
> other patches in progress.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message