lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From karl wettin <ka...@snigel.net>
Subject Re: Vector
Date Fri, 12 May 2006 23:38:38 GMT
On Fri, 2006-05-12 at 16:01 +0200, karl wettin wrote:
> > Needs to be considered on a case-by-case basis IMO.
> > 
> > > Should I summarize the uses and post it here for
> > > discussion?

In lack of other the view from someone that actually knows for sure,
here are my comments.


> StandardTokenizer:
>   private java.util.Vector jj_expentries

If the standard analyzer is not thread safe, does this make sense? Looks
genereted in my eyes. Did not look at the code.

> 
> Document:
>   List fields = new Vector();

ArrayList. People don't add fields from multiple threads?

> IndexWriter:
>   addIndexes(IndexReader[])
>     Vector segmentsToDelete
>   deleteFiles(Vector)
>     Vector deletable
>   deleteSegments(Vector)
>     Vector deletable
>   mergeSegments(int, int)
>     Vector segmentsToDelete
>   readDeleteableFiles()
>     Vector results

Located in methods. Vector makes no sense at all?

> 
> SegmentMerger:
>   private Vector readers

The IndexWriter keeps this instance synchronized?

>  
> TermVectorWriter:
>   terms = new Vector();

The IndexWriter keeps this instance synchronized?

> 
> MultiFieldQueryParser:
>   get(AnyKindOf)Query
>     Vector clauses


In methods. Vector makes no sense? Query parser is not thread safe, does
this have to be?

> 
> QueryParser:
>   private java.util.Vector jj_expentries
>   Query(String)
>     Vector caluses
>   getFieldQuery(String, String)
>     Vector v; // tokens from stream


In methods. Vector makes no sense? Query parser is not thread safe, does
this have to be?
  
> BooleanQuery:
>   private Vector clauses

People don't build a query from multiple threads?

> 
> BooleanQuery.BooleanWeight:
>   private Vector weights

People don't build a query from multiple threads?

> Hits:
>   private Vector hitDocs

Parallel hits collection might require this?

> MultiPhraseQuery:
>   private Vector positions

Unsure.

> PhraseQuery:
>   private Vector positions
>   private Vector terms

People don't build a query from multiple threads?


> RAMFile:
>   private Vector buffers

The IndexWriter keeps this instance synchronized?



---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message