lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "paul.elschot (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-413) [PATCH] BooleanScorer2 ArrayIndexOutOfBoundsException + alternative NearSpans
Date Mon, 03 Apr 2006 17:51:17 GMT
    [ http://issues.apache.org/jira/browse/LUCENE-413?page=comments#action_12372978 ] 

paul.elschot commented on LUCENE-413:
-------------------------------------

>> The same documents still match in the tests, only some score values change. 
> Could you elaborate on this point? Are the old or new scores correct? 

>From a quick look the new scorer look better than the old ones. In one of the test
docs the test query matches 3 times, and it now scores higher than the doc with the single
match
(the one in which only docs D and A match).
 
> > I don't know whether DisjunctionSumScorerPatch5.txt is still needed, but it should
not hurt. 
> I was going to commit that one anyway... it looks like a bug if skipTo(target) is called
with target<= currentDoc.
> Most scorers wouldn't do that, so I don't know if it's ever manifested as an error.

The two changes (in DisjunctionSumScorerPatch5.txt and in the posted SpanScorer) are different
in that
for DisjunctionSumScorer the test is against the current doc of the scorer and in
SpanScorer the test is against the current doc of the subscorer.
So I think in DisjunctionSumScorer  the test may not be needed, but in SpanScorer it should
be there.

However, I don't have a test case showing the out of bounds problem, so I'd like to know
whether this problem persists with the posted SpanScorer.



> [PATCH] BooleanScorer2 ArrayIndexOutOfBoundsException + alternative NearSpans
> -----------------------------------------------------------------------------
>
>          Key: LUCENE-413
>          URL: http://issues.apache.org/jira/browse/LUCENE-413
>      Project: Lucene - Java
>         Type: Bug

>   Components: Search
>     Versions: CVS Nightly - Specify date in submission
>  Environment: Operating System: other
> Platform: Other
>     Reporter: paul.elschot
>     Assignee: Lucene Developers
>  Attachments: DisjunctionSumScorerPatch3.txt, DisjunctionSumScorerPatch4.txt, DisjunctionSumScorerPatch5.txt,
DisjunctionSumScorerTestPatch1.txt, NearSpansOrdered.java, NearSpansOrderedBugHuntPatch1.txt,
NearSpansUnordered.java, SpanNearQueryPatch1.txt, SpanScorer.java, SpanScorerTestPatch1.txt,
TestSpansAdvanced.java, TestSpansAdvanced2.java
>
> From Erik's post at java-dev: 
>  
> >      [java] Caused by: java.lang.ArrayIndexOutOfBoundsException: 4 
> >      [java]     at org.apache.lucene.search.BooleanScorer2  
> > $Coordinator.coordFactor(BooleanScorer2.java:54) 
> >      [java]     at org.apache.lucene.search.BooleanScorer2.score  
> > (BooleanScorer2.java:292) 
> ... 
>  
> and my answer: 
>  
> Probably nrMatchers is increased too often in score() by calling score() 
> more than once.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message