lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Doug Cutting <cutt...@apache.org>
Subject Re: 1.9 RC1
Date Thu, 02 Mar 2006 19:19:37 GMT
Shay Banon wrote:
> ...
>     } else {
>       // is data larger then buffer?
>       if (length > BUFFER_SIZE) {
>         // we flush the buffer
>         if (bufferPosition > 0)
>           flush();
>         // and write data at once
>         flushBuffer(b, length);
>       } else {
> ...
> 
> the bufferStart is not incremented after the flushBuffer method is  
> called. So if someone calls getFilePointer just afterwards, it will  
> give the wrong result (hit it with the compound format). A simple fix  
> would be to add bufferStart += length; just after flushBuffer.

Can you please file a bug for this and attach a bug to it with a unit 
test that illustrates the problem?  This looks like something that could 
warrant a 1.9.1 release, so we must proceed carefully.

Thanks,

Doug

---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message