lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Paul Elschot <paul.elsc...@xs4all.nl>
Subject Re: NearSpans issue
Date Fri, 27 Jan 2006 20:29:54 GMT
On Friday 27 January 2006 16:33, Erik Hatcher wrote:
> One of the engineers decided to remove that exception to see what  
> effect it had on our particular troubling query:
> 
> Index: src/java/org/apache/lucene/search/spans/NearSpans.java
> ===================================================================
> --- src/java/org/apache/lucene/search/spans/NearSpans.java       
> (revision 372606)
> +++ src/java/org/apache/lucene/search/spans/NearSpans.java       
> (working copy)
> @@ -288,7 +288,8 @@
>          // When queue is empty and checkSlop() and ordered there is  
> a match.
>        }
>      }
> -    throw new RuntimeException("Unexpected: ordered");
> +    //throw new RuntimeException("Unexpected: ordered");
> +    return false;
>    }
> 
>    private void listToQueue() {
> 
> 
> And the error with that query went away and the results were accurate.

A pragmatic approach.
 
> I realize this isn't the long-term fix, but wanted to report where  
> things stand.

At the time this code fixed another bug in the span logic.
I vaguely recall that I was not certain what should be done
when the execution reaches that particular point, and I put the exception
in to make sure that something would be done about it when needed.
So it is actually unfinished code, and next time I'll try harder not to
use that way of coding again.

> 
> I'm still going to patch things up locally with those JIRA patches  
> and see where that takes it.  We've not had success building a  
> generic index that we can share that duplicates this issue,  
> unfortunately.

I hope those patches solve the problem.

Regards,
Paul Elschot

---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message