Mailing-List: contact java-dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
Reply-To: java-dev@lucene.apache.org
Received-SPF: pass (asf.osuosl.org: local policy)
Content-class: urn:content-classes:message
MIME-Version: 1.0
Subject: RE: IndexWriter.addIndexes(Directory[] dirs)
Date: Mon, 12 Dec 2005 14:58:10 -0800
Message-ID: 
 <C5591FFA3C85F546BB0DD8C9448569EB3E91B5@exsfo-mb03.internal.salesforce.com>
Thread-Topic: IndexWriter.addIndexes(Directory[] dirs)
Thread-Index: AcX/Iy1JJVzpsrAqTA2lpRd5yqvYugASnNOQAABz6fA=
From: "Kevin Oliver" <KOliver@salesforce.com>
To: java-dev@lucene.apache.org
Content-Type: multipart/alternative;
 boundary="----_=_NextPart_001_01C5FF6F.8624E8C5"

------_=_NextPart_001_01C5FF6F.8624E8C5
Content-Type: text/plain;
 charset=us-ascii
Content-Transfer-Encoding: quoted-printable

I see it stripped my attachment off. Here's the code:

=20

=20

import junit.framework.TestCase;

=20

import org.apache.lucene.analysis.standard.StandardAnalyzer;

import org.apache.lucene.document.Document;

import org.apache.lucene.document.Field;

import org.apache.lucene.index.IndexWriter;

import org.apache.lucene.index.Term;

import org.apache.lucene.search.*;

import org.apache.lucene.store.Directory;

import org.apache.lucene.store.FSDirectory;

=20

public class AddIndexesTest extends TestCase {

=20

    public AddIndexesTest(String name) {

        super(name);

    }

=20

    public void testAddIndexes() throws Exception {

        {

            Directory dir1 =3D
FSDirectory.getDirectory("/dev/searchdata/addIndexesTest1", true);

            IndexWriter writer1 =3D new IndexWriter(dir1, new
StandardAnalyzer(), true);

           =20

            Document doc1 =3D new Document();

            doc1.add(Field.UnIndexed("ID", "id1"));

            doc1.add(Field.UnStored("f", "some words"));

            writer1.addDocument(doc1);

           =20

            writer1.close();

            dir1.close();

           =20

            IndexSearcher searcher =3D new
IndexSearcher("/dev/searchdata/addIndexesTest1");

            Hits hits =3D searcher.search(new TermQuery(new Term("f",
"words")));

            assertEquals(1, hits.length());

            searcher.close();

        }

       =20

        {

            Directory dir2 =3D
FSDirectory.getDirectory("/dev/searchdata/addIndexesTest2", true);

            IndexWriter writer2 =3D new IndexWriter(dir2, new
StandardAnalyzer(), true);

           =20

            Document doc1 =3D new Document();

            doc1.add(Field.UnIndexed("ID", "id2"));

            doc1.add(Field.UnStored("f", "some other words"));

            writer2.addDocument(doc1);

           =20

            writer2.close();

            dir2.close();

=20

            IndexSearcher searcher =3D new
IndexSearcher("/dev/searchdata/addIndexesTest2");

            Hits hits =3D searcher.search(new TermQuery(new Term("f",
"words")));

            assertEquals(1, hits.length());

            searcher.close();

        }       =20

       =20

        Directory dir =3D
FSDirectory.getDirectory("/dev/searchdata/addIndexesTest1", false);

        IndexWriter writer =3D new IndexWriter(dir, new
StandardAnalyzer(), false);

        writer.addIndexes(new Directory[] {
FSDirectory.getDirectory("/dev/searchdata/addIndexesTest2", false) });

        writer.close();

        dir.close();

       =20

        IndexSearcher searcher =3D new
IndexSearcher("/dev/searchdata/addIndexesTest1");

        Hits hits =3D searcher.search(new TermQuery(new Term("f",
"words")));

        assertEquals(2, hits.length());

        searcher.close();

    }

   =20

}

=20

=20

-----Original Message-----
From: Kevin Oliver=20
Sent: Monday, December 12, 2005 2:53 PM
To: java-dev@lucene.apache.org
Subject: RE: IndexWriter.addIndexes(Directory[] dirs)

=20

Volodymyr, I tried this patch out, and unfortunately it doesn't appear

to work for me. Is there something I missed?

=20

I'll try attaching my Junit test case that works when the code is

unpatched, but fails on the final assertion expecting 2 hits (on line

63) when I used the patched IndexWriter.java.=20

=20

Thanks,=20

Kevin

=20

=20

-----Original Message-----

From: Volodymyr Bychkoviak [mailto:vbychkoviak@i-hypergrid.com]=20

Sent: Monday, December 12, 2005 5:51 AM

To: java-dev@lucene.apache.org

Subject: IndexWriter.addIndexes(Directory[] dirs)

=20

IndexWriter in addIndexes(Directory[] dirs) method optimizes index=20

before and after operation.

=20

Some notes about this:

1). Adding sub indexes to large index can take long because of double=20

optimization.

2). This breaks IndexWriter.maxMergeDocs logic, because optimize will=20

merge data into single segment index.

=20

I suggest add new method with boolean parameter to optionally specify=20

whether index should be optimized.

=20

There is similar method addIndexes(IndexReader[] readers) in IndexWriter

=20

that takes array of IndexReaders but I don't know how it can be modified

=20

to provide same optional functionality

=20

Patch attached here to discuss it first

(should I post it directly to jira?)

=20

=20

--=20

regards,

Volodymyr Bychkoviak

=20

=20

=20

=20

=20


------_=_NextPart_001_01C5FF6F.8624E8C5--