lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sam Hough (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-129) Finalizers are non-canonical
Date Wed, 16 Nov 2005 13:44:28 GMT
    [ http://issues.apache.org/jira/browse/LUCENE-129?page=comments#action_12357779 ] 

Sam Hough commented on LUCENE-129:
----------------------------------

I think FSDirectory needs a finalize method adding to remove its reference
from FSDirectory.DIRECTORIES otherwise, through normal garbage collection,
directories could linger.

I presume the orginator of this issue is commenting on the finalize methods for
the Input and Output Streams.

I'm assuming that the intention is for Lucene to clean up after itself even if close is
not called explicitly. If this really is a bug then I'm happy to try and construct a unit
test to check that FSDirectory cleans up after itself properly.


> Finalizers are non-canonical
> ----------------------------
>
>          Key: LUCENE-129
>          URL: http://issues.apache.org/jira/browse/LUCENE-129
>      Project: Lucene - Java
>         Type: Bug
>   Components: Other
>     Versions: unspecified
>  Environment: Operating System: other
> Platform: All
>     Reporter: Esmond Pitt
>     Assignee: Lucene Developers
>     Priority: Minor

>
> The canonical form of a Java finalizer is:
> protected void finalize() throws Throwable()
> {
>  try
>  {
>    // ... local code to finalize this class
>  }
>  catch (Throwable t)
>  {
>  }
>  super.finalize(); // finalize base class.
> }
> The finalizers in IndexReader, IndexWriter, and FSDirectory don't conform. This
> is probably minor or null in effect, but the principle is important.
> As a matter of fact FSDirectory.finaliz() is entirely redundant and could be
> removed, as it doesn't do anything that RandomAccessFile.finalize would do
> automatically.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message