From java-dev-return-11869-apmail-lucene-java-dev-archive=lucene.apache.org@lucene.apache.org Wed Oct 12 16:01:51 2005 Return-Path: Delivered-To: apmail-lucene-java-dev-archive@www.apache.org Received: (qmail 40092 invoked from network); 12 Oct 2005 16:01:51 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 12 Oct 2005 16:01:51 -0000 Received: (qmail 3583 invoked by uid 500); 12 Oct 2005 16:01:48 -0000 Delivered-To: apmail-lucene-java-dev-archive@lucene.apache.org Received: (qmail 3358 invoked by uid 500); 12 Oct 2005 16:01:46 -0000 Mailing-List: contact java-dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: java-dev@lucene.apache.org Delivered-To: mailing list java-dev@lucene.apache.org Received: (qmail 3347 invoked by uid 99); 12 Oct 2005 16:01:46 -0000 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received: from [192.87.106.226] (HELO ajax.apache.org) (192.87.106.226) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 12 Oct 2005 09:01:46 -0700 Received: from ajax.apache.org (ajax.apache.org [127.0.0.1]) by ajax.apache.org (Postfix) with ESMTP id 47EEC512 for ; Wed, 12 Oct 2005 18:01:25 +0200 (CEST) Message-ID: <102242993.1129132885081.JavaMail.jira@ajax.apache.org> Date: Wed, 12 Oct 2005 18:01:25 +0200 (CEST) From: "Guillaume Blain (JIRA)" To: java-dev@lucene.apache.org Subject: [jira] Commented: (LUCENE-452) PrefixQuery is missing the equals() method In-Reply-To: <1205257074.1129065125141.JavaMail.jira@ajax.apache.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N [ http://issues.apache.org/jira/browse/LUCENE-452?page=comments#action_12331899 ] Guillaume Blain commented on LUCENE-452: ---------------------------------------- I'd just like to say that I simply copied and changed the class casting of the TermQuery's equals and hashcode to the PrefixQuery's internals which suggest they might in fact have a common ancestor class with those two methods (and perharps other Query classes as well). I'm happy to see this promptly resolved, but I wouldn't like to take credit that isn't mine :) > PrefixQuery is missing the equals() method > ------------------------------------------ > > Key: LUCENE-452 > URL: http://issues.apache.org/jira/browse/LUCENE-452 > Project: Lucene - Java > Type: Improvement > Versions: 1.9 > Reporter: Guillaume Blain > Priority: Minor > Fix For: 1.9 > Attachments: PrefixQuery.java > > The PrefixQuery is inheriting the java.lang.Object's object default equals method. This makes it hard to have test working of PrefixFilter or any other task requiring equals to work proerply (insertion in Set, etc.). The equal method should be very similar, not to say identical except for class casting, to the equals() of TermQuery. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org For additional commands, e-mail: java-dev-help@lucene.apache.org