Mailing-List: contact java-dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
Reply-To: java-dev@lucene.apache.org
Message-ID: <1529706100.1127288368390.JavaMail.jira@ajax.apache.org>
Date: Wed, 21 Sep 2005 09:39:28 +0200 (CEST)
From: "Lukas Zapletal (JIRA)" <jira@apache.org>
To: java-dev@lucene.apache.org
Subject: [jira] Commented: (LUCENE-435) [PATCH] BufferedIndexOutput -
 optimized writeBytes() method
In-Reply-To: <1467497219.1127204314175.JavaMail.jira@ajax.apache.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

    [ http://issues.apache.org/jira/browse/LUCENE-435?page=comments#action_12330074 ] 

Lukas Zapletal commented on LUCENE-435:
---------------------------------------

Will fix this.

> [PATCH] BufferedIndexOutput - optimized writeBytes() method
> -----------------------------------------------------------
>
>          Key: LUCENE-435
>          URL: http://issues.apache.org/jira/browse/LUCENE-435
>      Project: Lucene - Java
>         Type: Improvement
>   Components: Store
>     Reporter: Lukas Zapletal
>     Priority: Minor
>  Attachments: BufferedIndexOutputWriteBytes.patch
>
> I have created a patch that optimize writeBytes metod:
>   public void writeBytes(byte[] b, int length) throws IOException {
>     if (bufferPosition > 0) // flush buffer
>       flush();
>  
>     if (length < BUFFER_SIZE) {
>       flushBuffer(b, length);
>       bufferStart += length;
>     } else {
>       int pos = 0;
>       int size;
>       while (pos < length) {
>         if (length - pos < BUFFER_SIZE) {
>           size = length - pos;
>         } else {
>           size = BUFFER_SIZE;
>         }
>         System.arraycopy(b, pos, buffer, 0, size);
>         pos += size;
>         flushBuffer(buffer, size);
>         bufferStart += size;
>       }
>     }
>   }
> Its a much more faster now. I know that for indexing this not help much, but for copying files in the IndexStore this is so big improvement. Its about 400% faster that old implementation.
> The patch was tested with 300MB data, "ant test" sucessfuly finished with no errors.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org