lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Doug Cutting <cutt...@apache.org>
Subject IndexFileNames
Date Mon, 06 Jun 2005 18:32:25 GMT
bmesser@apache.org wrote:
> --- lucene/java/trunk/src/java/org/apache/lucene/store/FSDirectory.java (original)
> +++ lucene/java/trunk/src/java/org/apache/lucene/store/FSDirectory.java Mon Jun  6 10:52:12
2005
> @@ -52,8 +52,8 @@
>          if (name.endsWith("."+IndexReader.FILENAME_EXTENSIONS[i]))
>            return true;
>        }
> -      if (name.equals("deletable")) return true;
> -      else if (name.equals("segments")) return true;
> +      if (name.equals(Constants.INDEX_DELETABLE_FILENAME)) return true;
> +      else if (name.equals(Constants.INDEX_SEGMENTS_FILENAME)) return true;
>        else if (name.matches(".+\\.f\\d+")) return true;
>        return false;

This really belongs in the index package.  That way, when we change the 
set of files in an index, the changes will be localized.

So this, LuceneFileFilter, Constants.INDEX_* and 
IndexReader.FILENAME_EXTENSIONS, should all be moved to a common home in 
the index package, like org.apache.lucene.index.IndexFileNames.  Thoughts?

Doug

---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message