Mailing-List: contact java-dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
Reply-To: java-dev@lucene.apache.org
Received-SPF: pass (hermes.apache.org: local policy)
From: Paul Elschot <paul.elschot@xs4all.nl>
To: java-dev@lucene.apache.org
Subject: Re: [Performance] Streaming main memory indexing of single strings
Date: Tue, 3 May 2005 00:10:47 +0200
User-Agent: KMail/1.5.4
References: <950FF7DE40C2B64CAF80B564732927E1039E71E2@exchange.be.bvd>
 <200505022332.41691.paul.elschot@xs4all.nl>
 <c598e9e3716f05d2cbae9ebe39d38a62@lbl.gov>
In-Reply-To: <c598e9e3716f05d2cbae9ebe39d38a62@lbl.gov>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200505030010.47183.paul.elschot@xs4all.nl>

On Monday 02 May 2005 23:38, Wolfgang Hoschek wrote:
> > Yes, the svn trunk uses skipTo more often than 1.4.3.
> >
> > However, your implementation of skipTo() needs some improvement.
> > See the javadoc of skipTo of class Scorer:
> >
> > http://lucene.apache.org/java/docs/api/org/apache/lucene/search/ 
> > Scorer.html#skipTo(int)
> 
> What's wrong with the version I sent? Remeber that there can be at most  
> one document in a MemoryIndex. So the "target" parameter can safely be  
> ignored, as far as I can see.

Correct, I did not realize that there is only a single doc in the index.

> 
> >
> > In case the underlying scorers provide skipTo() it's even better to  
> > use that.
> >
> 
> The version I sent returns in O(1), if performance was your concern. Or  
> did you mean something else?

Since 0 is the only document number in the index, a

return target == 0;

might be nice for skipTo(). It doesn't really help performance, though,
and the next() works just as well.

Regards,
Paul Elschot.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org