lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Doug Cutting <cutt...@apache.org>
Subject Re: DO NOT REPLY [Bug 31841] - [PATCH] MultiSearcher problems with Similarity.docFreq()
Date Wed, 20 Apr 2005 19:58:12 GMT
bugzilla@apache.org wrote:
> http://issues.apache.org/bugzilla/show_bug.cgi?id=31841
> 
> 
> otis@apache.org changed:
> 
>            What    |Removed                     |Added
> ----------------------------------------------------------------------------
>              Status|NEW                         |RESOLVED
>          Resolution|                            |FIXED

When we deprecate things we should ensure:

1. That, if they're removed, everything else should keep working.

2. That they should indicate what should be used instead.

In Searchable.java we now have methods whose javadoc refers to 
deprecated methods, which will be a problem if those deprecated methods 
are removed.  These deprecated search methods also do not indicate what 
folks should call instead.  In each case applications should call a 
corresponding Searcher method.  But these Searcher methods do not yet 
exist, instead we only have implementations of the deprecated interface 
methods on Searcher subclasses.  So we need abstract methods on 
Searcher.  These methods should never be called on RemoteSearchable, 
since it should always be passed a Weight, and never a Query, and thus 
the RemoteSearchable implementations should be removed when the 
deprecated interface methods are removed.

I've attached a patch that implements this.

Objections?

Doug

Mime
View raw message