lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 31841] - [PATCH] MultiSearcher problems with Similarity.docFreq()
Date Tue, 05 Apr 2005 18:34:14 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=31841>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=31841





------- Additional Comments From chuck@manawiz.com  2005-04-05 20:34 -------
Here is what I think happened and, if so, the correct fix:
  1.  MultiPhraseQuery and the new BooleanQuery were both added in parallel to
Wolf's work.  We now have a merge conflict.
  2.  The addition of the throws IOException to these two classes is now
required for Weights, and so the change is correct.
  3.  The new protocol for Weight's is to NOT have a searcher field.  Instead,
they should keep a Similarity field.  Just like the other Weight's that Wolf's
patch addresses, these two classes only use the searcher field to access the
Similarity and/or the idf.  MultiPhraseQuery, which needs the idf, already has
an idf field.  So, identical to Wolf's other changes it is straightforward to
modify these two classes to eliminate the searcher field.
  4.  Eliminating the searcher field will elimninate the need for MultiSearcher
to be Serializable, therefore retracting that change.

I think that's right, and that the best fix is too conform the new Weights to
the new protocol for MultiSearcher compatibility.  I've also sent a message
directly to Wolf asking him to review this.

Chuck


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message