lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 31841] - [PATCH] MultiSearcher problems with Similarity.docFreq()
Date Tue, 05 Apr 2005 16:16:48 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=31841>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=31841





------- Additional Comments From chuck@manawiz.com  2005-04-05 18:16 -------
I made these comments last night, but somehow they aren't here.  Sorry if a
duplicate pops up in the wrong place somewhere...

I don't think all of the changes are correct and feel we need Wolf to comment on
this as his message states that he ran the unit tests successfully on his code
as submitted.  Specifically, it looks to me like:
  1.  The additions of throws IOException to Weights are correct, and due to new
Weights added in parallel to Wolf's work.
  2.  I do not believe adding the searcher field back to TermWeight is correct.
 Wolf explicitly pulled this field out and replaced all references to it with
references to similarity or idf.  What caused the field to be added back?
  3.  Making MultiSearcher implement Serializable seems strange -- I don't
understand why in the protocol this would be requried.  It does not seem right.

Chuck

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message