lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 31841] - [PATCH] MultiSearcher problems with Similarity.docFreq()
Date Tue, 05 Apr 2005 02:32:17 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=31841>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=31841





------- Additional Comments From otis@apache.org  2005-04-05 04:31 -------
I applied this patch (2005-02-22 version) locally, but it doesn't compile as is.
 It looks like I need to add "throws IOException" to
BooleanQuery.BooleanWeight2.createWeight(Searcher) methods, and also to
MultiPhraseQuery.createWeight(Searcher) method.

It looks like I also need to modify TermQuery.TermWeight and add a searcher
declaration (private Searcher searcher;), plus the searcher assignment to the
constructor (this.searcher = searcher).

After these 2-3 changes Lucene compile.  Are my changes OK?

Unfortunately, unit tests fail in a few places, and it looks like all failures
have to do with RemoteSearchable.  Re-reading the comments in this bug entry, it
looks like this was a known issue at one point, but Wolf noted the following on
2004-11-15:

"Both problems mentioned in my previous comment (thread-safety and remote
searcher compatibility) are solved by this patch. All test cases work
unchanged with the exception of one test case which had been tweaked
previously due to the incorrect MultiSearcher and now works as expected
(TestSort.testNormalizedScores())."

This sounds like tests involving RemoteSearchable should pass now.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message