lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Paul Elschot <paul.elsc...@xs4all.nl>
Subject Re: DO NOT REPLY [Bug 32965] - [PATCH] Use filter bits for next() and skipTo() in FilteredQuery
Date Mon, 04 Apr 2005 17:14:19 GMT
On Monday 04 April 2005 11:34, Erik Hatcher wrote:
> I added Paul's SkipFilter and overwrote my FilteredQuery class from the  
> code here.  However, your FilteredQuery depends on two additional  
> classes: DocNrSkipper and SortedVIntList that are not provided.    
> Please attach those classes to this issue.

They are in one of the bugs the filter depends on:
http://issues.apache.org/bugzilla/show_bug.cgi?id=32921

> 
> I'm not personally fond of the abbreviation of "Number" to "Nr" - any  
> objections to spelling out "Number" entirely?

Not at all. My tradeoff between programming line length and
identifier readability is just slightly different. For me, number is
general enough to abbreviate in an identifier.
 
> Any others have objections to Paul's patches here?  I'll commit them  
> once I have everything working locally, unless I hear otherwise.

Please note the other dependency: this filter only works correctly when
documents are always scored in document number order.
This means that the bucket table of the 1.4.3 BooleanScorer can not
be used anymore, except when sorting is added.
See also the last comments I posted at that bug:
http://issues.apache.org/bugzilla/show_bug.cgi?id=33019
The (non ordered) bucket scoring mechanism the fastest one that is
available, anything else is slower, alhough not by much.

As for the assert statements: could you comment them out in case
the dependency on java 1.4 is not acceptable? That would
leave them useable for later.

Regards,
Paul Elschot


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message