Return-Path: Delivered-To: apmail-jakarta-lucene-dev-archive@www.apache.org Received: (qmail 88314 invoked from network); 2 Mar 2005 03:19:24 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur-2.apache.org with SMTP; 2 Mar 2005 03:19:24 -0000 Received: (qmail 90826 invoked by uid 500); 2 Mar 2005 03:19:21 -0000 Delivered-To: apmail-jakarta-lucene-dev-archive@jakarta.apache.org Received: (qmail 90796 invoked by uid 500); 2 Mar 2005 03:19:21 -0000 Mailing-List: contact lucene-dev-help@jakarta.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Subscribe: List-Help: List-Post: List-Id: "Lucene Developers List" Reply-To: "Lucene Developers List" Delivered-To: mailing list lucene-dev@jakarta.apache.org Received: (qmail 90781 invoked by uid 99); 2 Mar 2005 03:19:21 -0000 X-ASF-Spam-Status: No, hits=0.1 required=10.0 tests=FORGED_RCVD_HELO X-Spam-Check-By: apache.org Received-SPF: neutral (hermes.apache.org: local policy) Received: from zrnetservice.com (HELO wifi.zrnetservice.com) (209.133.52.163) by apache.org (qpsmtpd/0.28) with ESMTP; Tue, 01 Mar 2005 19:19:19 -0800 Received: from adsl-67-114-20-29.dsl.pltn13.pacbell.net ([67.114.20.29] helo=zrnet-Cole_Valley_Cafe.zrnetservice.com) by wifi.zrnetservice.com with asmtp (Exim 3.36 #1 (Debian)) id 1D6KOI-0004ws-00 for ; Tue, 01 Mar 2005 19:19:15 -0800 Received: from [10.100.1.240] (helo=[10.100.1.240]) by zrnet-Cole_Valley_Cafe.zrnetservice.com with esmtp (Exim 4.34 #1 (Debian)) id 1D6KOB-0000oG-Jg for ; Tue, 01 Mar 2005 19:19:07 -0800 Message-ID: <422530AB.2020805@newsmonster.org> Date: Tue, 01 Mar 2005 19:19:07 -0800 From: "Kevin A. Burton" User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7) Gecko/20040616 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Lucene Developers List Subject: Re: patch - DEFAULT_ vars in IndexWriter non-final and DEFAULT for useCompoundFile References: <421EE01C.7070501@newsmonster.org> <421F0FF7.9020306@l3s.de> <421F58E0.9060703@apache.org> <42225C0D.1000702@newsmonster.org> <42239E53.2030508@apache.org> In-Reply-To: <42239E53.2030508@apache.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N Doug Cutting wrote: > > This isn't a coding convention, but rather software engineering. If > we wish to be able to back-compatibly modify Lucene's implementation > at a later date, its usually easiest to have access through methods > rather than fields, since we can intecept reads and writes to the field. > Standard accessor/mutator stuff... but how often is it used? Rarely if ever... The point being there are a lot of benefits to just make it non-final. I sent an email to commons-dev about this. I should probably just blog about it so I can give you a permalink :) Kevin -- Use Rojo (RSS/Atom aggregator). Visit http://rojo.com. Ask me for an invite! Also see irc.freenode.net #rojo if you want to chat. Rojo is Hiring! - http://www.rojonetworks.com/JobsAtRojo.html If you're interested in RSS, Weblogs, Social Networking, etc... then you should work for Rojo! If you recommend someone and we hire them you'll get a free iPod! Kevin A. Burton, Location - San Francisco, CA AIM/YIM - sfburtonator, Web - http://peerfear.org/ GPG fingerprint: 5FB2 F3E2 760E 70A8 6174 D393 E84D 8D04 99F1 4412 --------------------------------------------------------------------- To unsubscribe, e-mail: lucene-dev-unsubscribe@jakarta.apache.org For additional commands, e-mail: lucene-dev-help@jakarta.apache.org