lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Engels" <>
Subject RE: Interfaces
Date Thu, 17 Mar 2005 15:58:24 GMT
I only speak from current project experience, where we've developed a
"search server" utilizing lucene , utilizing custom indexing formats in
order to support high-speed incremental indexing. It was necessary to extend
IndexReader in order to have the rest of the searching framework work
properly, even though I use NO METHODS in the base class. Seems silly.

-----Original Message-----
From: Erik Hatcher []
Sent: Thursday, March 17, 2005 5:31 AM
Subject: Re: Interfaces

I think, though I'm not speaking for anyone here but myself, that the
Lucene team is open to API improvements that _do not adversely affect
performance_ and that have _a real benefit_.

While I'm as IoC and design pattern savvy as the next developer, I'm
also highly pragmatic.  I've not been convinced by any of the examples
thus far.  If a unit test needs to detect if a document has been added,
you can check the size of the index before and after for example,
rather than doing some mock trickery to hook the addDocument call.  Or
you could use AspectJ to do this if you really wanted to get fancy.
The unit test example shown is really a unit test appropriate to Lucene
itself, and not to a project using Lucene, it seems.  Pragmatically,
have you ever had addDocument fail?  If not, then what peace of mind
are you getting from such a test?

Ultimately, though, the decision to refactor the codebase to use
interfaces more pervasively lies with Doug.


On Mar 17, 2005, at 2:40 AM, Konstantin Priblouda wrote:

> --- Robert Engels <> wrote:
>> I've been pushing for making IndexReader and
>> IndexWriter interfaces for a
>> long time (and changing lucene core to use them),
>> but there seems a
>> reluctance to do so (although I am not sure why).
>> The current factory
>> methods could be easily moved to a IndexReaderWriter
>> factory class. Probably
>> a top-level interface IndexReaderWriter with methods
>> like isWritable() for
>> "read only" indices, and methods getReader(),
>> getWriter().
> Hi guys,
> what about  making lucene a bit more IoC Friendly?
> ( I speak of providing objects that can be created wia
> constructor, and not by factory )
> I'm tired of writing adapter classes...
> regards,
> ----[ Konstantin Pribluda ( ko5tik ) ]----------------
> Plugins for xdoclet-2 are released. check it out at:
> ----[ ]------------------------
> __________________________________
> Do you Yahoo!?
> Yahoo! Small Business - Try our new resources site!
> ---------------------------------------------------------------------
> To unsubscribe, e-mail:
> For additional commands, e-mail:

To unsubscribe, e-mail:
For additional commands, e-mail:

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message