lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 33389] - [PATCH] Highlighter: Delegate output escaping to Formatter
Date Thu, 03 Feb 2005 17:26:42 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=33389>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=33389





------- Additional Comments From markharw00d@yahoo.co.uk  2005-02-03 18:26 -------
> This patch allows the highlighter Formatter to control escaping of the non
> highlighted text as well as the highlighting of the matching text.

Thanks for this. I think the suggestion looks useful but I have a couple of
concerns. Not only do we break the Formatter interface, we also break the
behaviour for those upgrading. If people have applications which already escape
the content (eg before or after calling highlighter), when they upgrade to the
proposed new version their content will be double-escaped. They will also incur
 the additional performance overhead for encoding where it may not be required
(Note: could initialize htmlEncode's StringBuffer to at least plainText.length()) . 
Either we could add a flag to the html-based formatters which allows the user to
turn encoding on or off or we could suggest they subclass to override
encodeText. Will the htmlEncode function you've defined work for more exotic
character sets eg CKY?


Cheers
Mark

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: lucene-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: lucene-dev-help@jakarta.apache.org


Mime
View raw message