lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 31785] - DisjunctionScorer
Date Sat, 22 Jan 2005 22:25:08 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=31785>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=31785


paul.elschot@xs4all.nl changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #13147|0                           |1
        is obsolete|                            |
  Attachment #13148|0                           |1
        is obsolete|                            |
  Attachment #13149|0                           |1
        is obsolete|                            |
  Attachment #13358|0                           |1
        is obsolete|                            |
  Attachment #13739|0                           |1
        is obsolete|                            |
  Attachment #14067|0                           |1
        is obsolete|                            |




------- Additional Comments From paul.elschot@xs4all.nl  2005-01-22 23:25 -------
Created an attachment (id=14069)
 --> (http://issues.apache.org/bugzilla/attachment.cgi?id=14069&action=view)
Reworked BooleanScorer2 to drop NrMatchersScorer.

Adding BooleanScorer2 to Lucene, 22 Jan 2005.

The main difference with the previous patch of 12 Dec 2004
is that all counting of matching scorers is now done
locally in BooleanQuery2 using a wrapper and a few
inline subclasses.

This allowed to get rid of NrMatchersScorer completely.
ConjunctionScorer is used as a summing scorer by passing
it a default similarity.

The copyright is now assigned to the Apache Software Foundation.

The implementation of explain() is still in its infancy.
Some "Expert:" annotations may still be needed in the javadocs.


The code, all under Apache Licence Version 2:

Test for BooleanScorer, with some example code
using both 1.4 scorer and new BooleanScorer2:
src/test/org/apache/lucene/search/TestBoolean2.java
(Functionality unchanged from 12 Dec 2004)

Alternative for BooleanScorer, using the scorers below:
src/java/org/apache/lucene/search/BooleanScorer2.java
(Functionality changed heavily, see above).

Counterpart of ConjunctionScorer, also allowing a
minimal nr of matchers:
src/java/org/apache/lucene/search/DisjunctionSumScorer.java
(Functionality unchanged from 12 Dec 2004, keeping
the nrMatchers() method but not implementing NrMatchersScorer.)

Helper for case of only prohibited subscorers:
src/java/org/apache/lucene/search/NonMatchingScorer.java
I would suggest to also use this in other places instead of
a null Scorer, that's why it is in a separate java file.

For required and prohibited subscorers:
src/java/org/apache/lucene/search/ReqExclScorer.java
(Functionality unchanged from 12 Dec 2004, except
for removing the nrMatchers() method.)

For required and optional subscorers:
src/java/org/apache/lucene/search/ReqOptSumScorer.java
(Functionality unchanged from 12 Dec 2004, except
for removing the nrMatchers() method. The score()
method was simplified a bit.)


Changes to existing code:

Redirect BooleanQuery to BooleanScorer2 under
control of static methods setUseScorer14 and getUseScorer14,
default using BooleanScorer2, as requested by Doug:
src/java/org/apache/lucene/search/BooleanQuery.java
(Unchanged from the previous version of 12 Dec 2004)

Added some helping code for tests by TestBoolean2,
This uses the setUseScorer14 method to test both versions:
src/test/org/apache/lucene/search/CheckHits.java
(Unchanged from the previous version of 12 Dec 2004)

ConjunctionScorer is no more declared final,
and the imports are explicit:
src/java/org/apache/lucene/search/ConjunctionScorer.java

Regards,
Paul Elschot


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: lucene-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: lucene-dev-help@jakarta.apache.org


Mime
View raw message