lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 31785] - DisjunctionScorer
Date Wed, 19 Jan 2005 19:55:40 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=31785>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=31785





------- Additional Comments From goller@detego-software.de  2005-01-19 20:55 -------
Hi Paul,

I finally found time to look into your code in detail and I think
it's really excellent work. Before committing it, I have a few questions.

*) In your source files you have included a copyright statement referring
to yourself. Of course you include the Apache License. However, I haven't seen
other source files in Lucene with similar copyright statements. I don't know the
legal consequences of that. Maybe someone else on the list knows more. The
simplest solution would be to substitute "Copyright 2004 Paul Elschot" with
"Copyright 2004 The Apache Software Foundation". Would you agree?

*) BooleanScorer2 extends NrMatchersScorer and nrMatchers() always returns 1. 
Is there a reason for that? I think it should either only extend Scorer or
deliver the correct values. I opt for extending Scorer only.

*) All NrMatchersScorers except for BooleanScorer2 and ConjunctionScorer don't
use a similarity implementation. They compute raw scores and nrMatches.
ConjunctionScorer is a hybrid. It uses coord-factors and is is used as
NrMatchersScorer. This could lead to incorrect results with Similarity
implementations other than DefaultSimilarity. A ConjunctionScorer used as
NrMathesScorer should compute raw scores, if used as standard Scorer it 
should use coord-factors. How can we achieve this in an elegant way?

Christoph

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: lucene-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: lucene-dev-help@jakarta.apache.org


Mime
View raw message