Mailing-List: contact lucene-dev-help@jakarta.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Lucene Developers List" <lucene-dev@jakarta.apache.org>
Received-SPF: neutral (hermes.apache.org: local policy)
Message-ID: <41A9F15F.60900@apache.org>
Date: Sun, 28 Nov 2004 16:40:15 +0100
From: Bernhard Messer <bmesser@apache.org>
User-Agent: Mozilla Thunderbird 0.8 (X11/20040913)
MIME-Version: 1.0
To: Lucene Developers List <lucene-dev@jakarta.apache.org>
Subject: Re: cvs commit: jakarta-lucene/src/test/org/apache/lucene/queryParser
 TestQueryParser.java
References: <20041123231431.77630.qmail@minotaur.apache.org>
 <E708E2F1-3DFE-11D9-97B1-000393A564E6@ehatchersolutions.com>
 <200411242023.10130@danielnaber.de>
 <9A9C69A0-3E52-11D9-A4B6-000A95BC61B6@ehatchersolutions.com>
 <41A4F8B4.30402@apache.org> <41A5EF2A.2040402@detego-software.de>
 <41A62C9D.7080608@apache.org>
In-Reply-To: <41A62C9D.7080608@apache.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

Bernhard Messer schrieb:

>
>>>> Or maybe we could put together an all-encompassing 
>>>> TestDeprecatedMethods that at least had calls to all the methods 
>>>> we've deprecated, but doesn't necessarily test return values or 
>>>> behavior.  Then we could fix all the deprecation warnings in the 
>>>> other test cases and leave this as the one test that at least the 
>>>> method signatures are viable (and we can be reasonably sure that if 
>>>> the method signatures still work that the behavior has not changed, 
>>>> I presume).
>>>>
>>> creating an all-encompassing TestDeprecatedMethods class seems to be 
>>> more difficult than it looks for the moment. Wouldn't it be easier 
>>> to copy the Testcases from 1.4.2 in a seperate, new folder 
>>> "test-deprecated" and leave them as they are. All work, removing 
>>> deprecation warnings, add new test cases could be done without 
>>> modifying the originals within the new folder. When we run the 
>>> ant-task on both directories, we can make sure that both, the 
>>> deprecated and new methods are working properly.
>>
>>
>>
>> +1
>> seems to do what we want with minimal effort
>>
> I tried it on my local environement and it looks fine to me. It's not 
> that much work to create a copy of the test cases from 1.4.2. Adding a 
> new ant task "test-deprecated" which uses the test classes located in 
> "src/test-deprecated" is a is trivial too. At least it is just a copy 
> of the existing "test" task with modified directory names. Having all 
> together, users can run both tests "ant test" or "ant 
> test-deprecated". The only question still open, if we want to have all 
> the duplicated test cases in CVS or do we leave it to the user if he 
> wants to run the outdated, deprecated tests. My suggestion is to add 
> both, the modified build.xml and the test cases to CVS and delete them 
> step by step when switching to version 2.0
>
if there are no votes against it, i will add the deprecated tests as 
described above and commit the modification in  build.xml.

Bernhard

>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: lucene-dev-unsubscribe@jakarta.apache.org
>> For additional commands, e-mail: lucene-dev-help@jakarta.apache.org
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: lucene-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: lucene-dev-help@jakarta.apache.org
>


---------------------------------------------------------------------
To unsubscribe, e-mail: lucene-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: lucene-dev-help@jakarta.apache.org