Return-Path: Delivered-To: apmail-jakarta-lucene-dev-archive@www.apache.org Received: (qmail 77858 invoked from network); 4 Nov 2004 04:16:51 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur-2.apache.org with SMTP; 4 Nov 2004 04:16:51 -0000 Received: (qmail 48667 invoked by uid 500); 4 Nov 2004 04:16:19 -0000 Delivered-To: apmail-jakarta-lucene-dev-archive@jakarta.apache.org Received: (qmail 48641 invoked by uid 500); 4 Nov 2004 04:16:19 -0000 Mailing-List: contact lucene-dev-help@jakarta.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Subscribe: List-Help: List-Post: List-Id: "Lucene Developers List" Reply-To: "Lucene Developers List" Delivered-To: mailing list lucene-dev@jakarta.apache.org Received: (qmail 48628 invoked by uid 99); 4 Nov 2004 04:16:19 -0000 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (hermes.apache.org: domain of brian@quiotix.com designates 199.164.185.7 as permitted sender) Received: from [199.164.185.7] (HELO lx.quiotix.com) (199.164.185.7) by apache.org (qpsmtpd/0.28) with ESMTP; Wed, 03 Nov 2004 20:16:18 -0800 Received: from [127.0.0.1] (lx.quiotix.com [127.0.0.1]) by lx.quiotix.com (8.12.11/8.12.11) with ESMTP id iA44GEV8003063 for ; Wed, 3 Nov 2004 20:16:17 -0800 Message-ID: <4189AD1A.4000006@quiotix.com> Date: Wed, 03 Nov 2004 23:16:26 -0500 From: Brian Goetz User-Agent: Mozilla Thunderbird 0.8 (Windows/20040913) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Lucene Developers List Subject: Re: Question about PorterStemFilter class References: <20041029140952.86849.qmail@web12702.mail.yahoo.com> <6CDD372A-29B6-11D9-8E51-000A95BC61B6@ehatchersolutions.com> <41825612.5080302@open.ac.uk> In-Reply-To: <41825612.5080302@open.ac.uk> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N The original (Porter) version did indeed not correspond to any current Java coding standards -- because (a) it was translated to Java before such standards emerged (JDK 1.0) and (b) translated from another language. I left these as is, rather than attempt to clean them up. > Yes, I understand that. In looking at the code it is quite obviously > of the same origin (i.e. from Martin Porter) but may be an older > version (I couldn't quite tell). It doesn't come close to any normal > Java programming guidelines, and while I didn't try to modify the > latest version so that it would, entirely, because part of the > reason I think whoever wrote the original code formatted it the way > they did was to enable an easier reading of the comparison strings. > I've tried to come to some compromise, as well as (as I mentioned) > predeclaring the Strings so that the VM isn't constantly recreating > them. --------------------------------------------------------------------- To unsubscribe, e-mail: lucene-dev-unsubscribe@jakarta.apache.org For additional commands, e-mail: lucene-dev-help@jakarta.apache.org