lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mike Hearn <m.he...@signal.QinetiQ.com>
Subject Re: FSDirectory.makeLock() declared final
Date Tue, 31 Aug 2004 14:40:13 GMT
Doug Cutting wrote:
> Back in 1998, when FSDirectory was first written, 'final' did actually 
> make some things faster.  It permitted 'javac' to inline more things. It 
> also held the promise that future compilers might do more with it. Well, 
> now here we are in the future, and all we have are a bunch of final 
> declarations!
> 
> Note too that a few of Lucene's final declarations are there because 
> classes and/or methods really should not be overridden.  I don't think 
> FSDirectory falls into this category.  So I support making FSDirectory 
> and its methods non-final.

OK, do you want to write the patch or shall I?

thanks -mike

---------------------------------------------------------------------
To unsubscribe, e-mail: lucene-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: lucene-dev-help@jakarta.apache.org


Mime
View raw message