lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Christoph Goller <gol...@detego-software.de>
Subject Re: API cleanup for Field
Date Mon, 30 Aug 2004 11:20:58 GMT
Daniel Naber wrote:
> Hi,
> 
> here's a patch to clean up the API as described by Doug:
> http://www.mail-archive.com/lucene-user%40jakarta.apache.org/msg08479.html
> 
> The Field constructor with three booleans is deprecated because it's too 
> easy to mix up the order of those parameters. Also, one variation of 
> Field.Text() is deprecated because it behaves different depending on if 
> you pass it a String or a StringReader, which is very confusing.
> 
> The static Field.UnStored/Keyword etc methods are not deprecated. I think 
> these can be confusing (e.g. what exactly does UnIndexed mean -- I always 
> have to look it up), but nobody is forced to use them so there's no reason 
> to deprecate them.
> 
> The only boolean left is the one for term vectors. Should we add another 
> enumeration like TermVectorIndex.NO/YES/...? I know that there's a patch 
> that adds position information to the term vectors. How does that fit in 
> here?

+1
Your patch looks ok for me. I haven't looked into the Termvector-positions
patch. Anyway, an enumeration like TermVectorIndex.NO/YES/..., that could be
extended for Termvector-positions if necessary, seems reasonable.

Christoph


---------------------------------------------------------------------
To unsubscribe, e-mail: lucene-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: lucene-dev-help@jakarta.apache.org


Mime
View raw message