lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Paul Elschot <paul.elsc...@xs4all.nl>
Subject Re: bitwise OR in BooleanScorer
Date Sun, 15 Aug 2004 10:12:41 GMT
On Saturday 14 August 2004 17:15, Daniel Naber wrote:
> Hi,
>
> BooleanScorer's next() method uses a bitwise OR in a while loop:
>
> ...} while (bucketTable.first != null | more);
>
> Is there any reason for this, couldn't this just be || ? BTW, I found this
> with FindBugs (http://findbugs.sourceforge.net/), which takes a jar files
> and gives some useful warnings about potential bugs.

Both expressions around the | are booleans, so a || would be better style.

Regards,
Paul


---------------------------------------------------------------------
To unsubscribe, e-mail: lucene-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: lucene-dev-help@jakarta.apache.org


Mime
View raw message