lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Erik Hatcher <e...@ehatchersolutions.com>
Subject Re: VOTE: Change Token to public
Date Tue, 20 Jul 2004 20:55:15 GMT
On Jul 20, 2004, at 3:47 PM, Doug Cutting wrote:
> Erik Hatcher wrote:
>> I'm voting, based on discussions on lucene-user, to make Token 
>> public.  +1
>
> I think you mean to make Token non-final, in which case I'm +1 too.

Oops, yes, I mean non-final.

> Probably we should also make the accessors non-final, make the fields 
> private and add setters for some (or all) of the fields.  This will 
> also require a few changes to other classes in the analysis package 
> which access the currently package private fields, making them instead 
> use accessors.  In short, we need a diff, complete with javadoc 
> comments.

Also, I implicitly intended for the changes you mention to take place 
for changes to the fields of Token.  Sorry, I should have specified 
that.

	Erik


---------------------------------------------------------------------
To unsubscribe, e-mail: lucene-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: lucene-dev-help@jakarta.apache.org


Mime
View raw message