Mailing-List: contact lucene-dev-help@jakarta.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Lucene Developers List" <lucene-dev@jakarta.apache.org>
Message-ID: <40841EFF.2060204@apache.org>
Date: Mon, 19 Apr 2004 11:48:31 -0700
From: Doug Cutting <cutting@apache.org>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040116
MIME-Version: 1.0
To: Lucene Developers List <lucene-dev@jakarta.apache.org>
Subject: Re: cvs commit: jakarta-lucene/src/java/org/apache/lucene/index
 MultiReader.java
 FilterIndexReader.java IndexReader.java SegmentReader.java
References: <20040416091706.57408.qmail@minotaur.apache.org>
 <40840AFB.8040906@apache.org> <40840E80.90804@detego-software.de>
In-Reply-To: <40840E80.90804@detego-software.de>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 8bit

Christoph Goller wrote:
>> The non-public SegmentInfos makes an appearance here in a public API. 
>> Perhaps this constructor should be package-private.
> 
> Both constructors of IndexReader or at least the one with SegmentInfos 
> should
> be made package-private. Thats probably better than protected.

We need at least one that's not package private, so that classes outside 
this package can implement the IndexReader API.

>> Or perhaps, since the SegmentInfos instance is only used once on line 
>> 414, for version checking, we should instead add an abstract 
>> getVersion() method implemented by subclasses.  Could that work?
> 
> Don�t know exactly what you mean here. We already have the 
> getCurrentVersion
> method in IndexReader, but you probably mean something else.

I was trying to think of a way to avoid having to pass the SegmentInfos 
to this constructor at all, since it is only used once to extract a 
long.  Perhaps one could simply pass the long in?  Perhaps the 
SegmentInfos field of IndexReader could be replaced with a version 
field.  I'm just trying to reduce the IndexReader's dependencies on 
package-private implementation stuff, to make it a more pure abstract 
class.  This is not high-priority.

> Do you agree to the changes concerning the bahavior of undeleteAll and 
> close?

Yes, I think these look good.

Doug

---------------------------------------------------------------------
To unsubscribe, e-mail: lucene-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: lucene-dev-help@jakarta.apache.org