Return-Path: Delivered-To: apmail-jakarta-lucene-dev-archive@www.apache.org Received: (qmail 29976 invoked from network); 19 Apr 2004 17:23:20 -0000 Received: from daedalus.apache.org (HELO mail.apache.org) (208.185.179.12) by minotaur-2.apache.org with SMTP; 19 Apr 2004 17:23:20 -0000 Received: (qmail 49227 invoked by uid 500); 19 Apr 2004 17:23:09 -0000 Delivered-To: apmail-jakarta-lucene-dev-archive@jakarta.apache.org Received: (qmail 49031 invoked by uid 500); 19 Apr 2004 17:23:08 -0000 Mailing-List: contact lucene-dev-help@jakarta.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Subscribe: List-Help: List-Post: List-Id: "Lucene Developers List" Reply-To: "Lucene Developers List" Delivered-To: mailing list lucene-dev@jakarta.apache.org Received: (qmail 49018 invoked from network); 19 Apr 2004 17:23:08 -0000 Received: from unknown (HELO rwcrmhc12.comcast.net) (216.148.227.85) by daedalus.apache.org with SMTP; 19 Apr 2004 17:23:08 -0000 Received: from apache.org (c-24-5-145-151.client.comcast.net[24.5.145.151]) by comcast.net (rwcrmhc12) with ESMTP id <2004041917231201400rkac7e>; Mon, 19 Apr 2004 17:23:12 +0000 Message-ID: <40840AFB.8040906@apache.org> Date: Mon, 19 Apr 2004 10:23:07 -0700 From: Doug Cutting User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040116 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Lucene Developers List Subject: Re: cvs commit: jakarta-lucene/src/java/org/apache/lucene/index MultiReader.java FilterIndexReader.java IndexReader.java SegmentReader.java References: <20040416091706.57408.qmail@minotaur.apache.org> In-Reply-To: <20040416091706.57408.qmail@minotaur.apache.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N Christoph, Thanks again for all of your work. This is a great patch. One nit, however: goller@apache.org wrote: > + protected IndexReader(Directory directory, SegmentInfos segmentInfos, boolean closeDirectory) { The non-public SegmentInfos makes an appearance here in a public API. Perhaps this constructor should be package-private. Or perhaps, since the SegmentInfos instance is only used once on line 414, for version checking, we should instead add an abstract getVersion() method implemented by subclasses. Could that work? Thanks again, Doug --------------------------------------------------------------------- To unsubscribe, e-mail: lucene-dev-unsubscribe@jakarta.apache.org For additional commands, e-mail: lucene-dev-help@jakarta.apache.org