lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Doug Cutting <cutt...@apache.org>
Subject Re: Fwd: cvs commit: jakarta-lucene/src/java/org/apache/lucene/analysis/de WordlistLoader.java
Date Wed, 10 Mar 2004 17:53:03 GMT
Erik Hatcher wrote:
> But here is the change to StopFilter that has been discussed.  I went  
> ahead and converted it to a Set.

Thanks, Erik.  This looks great.

> Do we really need makeStopSet to be  
> public?  If you have a String[], just call the constructor that takes  
> it would be my recommendation.  I'll happily make it protected.

It should be public, so that folks can easily cache the Set and reuse it 
for each document, rather than having to reconstruct it.  Have a look 
at, e.g. StopAnalysis.

Doug

---------------------------------------------------------------------
To unsubscribe, e-mail: lucene-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: lucene-dev-help@jakarta.apache.org


Mime
View raw message