lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jamie M <jami...@yahoo.com>
Subject Re: New FieldSortedHitQueue uses Java 1.4 feature
Date Sat, 13 Mar 2004 12:09:56 GMT
Terry,

I'm not sure what stripped the attachment (yahoo mail
or the list manager), but I've put it here:
http://mckinney.co.nz/java/FieldSortedHitQueueJava13.patch

I don't know if there is a patch in bugzilla like this
- this is the fix that I first proposed for the java
1.4 stuff, but I never provided a patch, only
described it in a post to this list.  So, Otis may be
referring to a different patch, but if so, it probably
uses the same approach to remove the java 1.4 regexp
stuff.

jamie

--- Terry Steichen <terry@net-frame.com> wrote:
> Jamie,
> 
> That's a good solution, but alas, there's no
> attachment to your post (in my
> copy, anyway).  Could you either enclose the patch
> within your e-mail (so it
> doesn't get stripped), and/or point me to the
> appropriate Bugzilla (or
> whatever) location?
> 
> Much thanks in advance,
> 
> Terry
> 
> PS: I assume this is the same patch that Otis
> referred to in response to my
> previous message?
> 
> ----- Original Message -----
> From: "Jamie M" <jamienz@yahoo.com>
> To: "Lucene Developers List"
> <lucene-dev@jakarta.apache.org>
> Sent: Saturday, March 13, 2004 5:53 AM
> Subject: Re: New FieldSortedHitQueue uses Java 1.4
> feature
> 
> 
> > If you're wanting to test the current cvs version
> then
> > check the code out from cvs and apply the patch
> > attached to this post.
> >
> > (copy the patch into the directory that you ran
> the
> > cvs checkout command in, then run: patch <
> > FieldSortedHitQueueJava13.patch)
> >
> > Then compile, and you'll have a lucene 1.4 jar
> that
> > works on a 1.3 jvm.
> >
> > jamie
> >
> > --- Terry Steichen <terry@net-frame.com> wrote:
> > > I wonder if someone could clear up this issue. 
> I'd
> > > like to test the latest
> > > CVS version, but it won't compile (because it
> can't
> > > find
> > > java.util.regex.Pattern).  If this
> regex-dependency
> > > is to remain, is there a
> > > way that us non-1.4-JVM users could add some
> library
> > > to get around this
> > > problem?  Or, is there a plan to remove it, or
> at
> > > least make it optional?
> > >
> > > Regards,
> > >
> > > Terry
> > >
> > > ----- Original Message -----
> > > From: "Doug Cutting" <cutting@apache.org>
> > > To: "Lucene Developers List"
> > > <lucene-dev@jakarta.apache.org>
> > > Sent: Monday, March 08, 2004 1:33 PM
> > > Subject: Re: New FieldSortedHitQueue uses Java
> 1.4
> > > feature
> > >
> > >
> > > > Robert Engels wrote:
> > > > > Seems like a bad precedent... if developers
> have
> > > to worry about coding
> > > > > around problems in specific JDK's, it could
> be a
> > > nightmare. What about
> > > the
> > > > > next user who uses some JDK than is less
> > > mainstream?
> > > >
> > > > I think you're responding to the other branch
> of
> > > this thread!
> > > >
> > > > What I was suggesting here is that Tim remove
> the
> > > regex code from the
> > > > Lucene 1.4 codebase, since it requires Java
> 1.4,
> > > while everything else
> > > > in Lucene requires only Java 1.2.
> > > >
> > > > Separately, there's the issue of how Lucene
> should
> > > handle a bug in IBM's
> > > > 1.3 JIT, but that's not what I was talking
> about
> > > here.
> > > >
> > > > Doug
> > > >
> > > > > -----Original Message-----
> > > > > From: Doug Cutting
> [mailto:cutting@apache.org]
> > > > > Sent: Monday, March 08, 2004 11:57 AM
> > > > > To: Lucene Developers List
> > > > > Subject: Re: New FieldSortedHitQueue uses
> Java
> > > 1.4 feature
> > > > >
> > > > >
> > > > > Tim Jones wrote:
> > > > >
> > > > >>But, if this is the only code depending on
> java
> > > 1.4, it seems like it
> > > > >
> > > > > would
> > > > >
> > > > >>be better to remove it for better version
> > > compatibility.  Perhaps what
> > > > >
> > > > > would
> > > > >
> > > > >>be best would be to have the code detect
> which
> > > version it's running
> > > under
> > > > >>and act appropriately.
> > > > >
> > > > >
> > > > > I vote for just removing it, and keeping
> Lucene
> > > 1.4 compatible with Java
> > > > > 1.2.  I don't think it's worth trying to
> detect
> > > the version.  You might
> > > > > add a comment, or even a commented-out
> 1.4-based
> > > implementation, to mark
> > > > > this as something to revisit when we
> eventually
> > > move Lucene to Java 1.4.
> > > > >
> > > > > Doug
> > > > >
> > > > >
> > >
> >
> > __________________________________
> > Do you Yahoo!?
> > Yahoo! Mail - More reliable, more storage, less
> spam
> > http://mail.yahoo.com
> >
> 
> 
>
----------------------------------------------------------------------------
> ----
> 
> 
> >
>
---------------------------------------------------------------------
> > To unsubscribe, e-mail:
> lucene-dev-unsubscribe@jakarta.apache.org
> > For additional commands, e-mail:
> lucene-dev-help@jakarta.apache.org
> 
> 
>
---------------------------------------------------------------------
> To unsubscribe, e-mail:
> lucene-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail:
> lucene-dev-help@jakarta.apache.org
> 


__________________________________
Do you Yahoo!?
Yahoo! Mail - More reliable, more storage, less spam
http://mail.yahoo.com

---------------------------------------------------------------------
To unsubscribe, e-mail: lucene-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: lucene-dev-help@jakarta.apache.org


Mime
View raw message