lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 26702] - [PATCH] arbitrary sorting
Date Thu, 12 Feb 2004 18:31:12 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=26702>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=26702

[PATCH] arbitrary sorting





------- Additional Comments From cutting@apache.org  2004-02-12 18:31 -------
Sorry I haven't had a chance to respond in a couple of days.

This stuff looks great!

A few minor comments:

Is there a reason why you pass a SortField[] rather than a Sort in
Searchable#search()?

For distributed search to work correctly I think you'll need to make Sort and
SortField implement Serializeable.

In addition to javadoc for all public classes and methods, we'll need some
simple unit tests that, e.g., test each sort type, test each searchable
implementation, etc.

Thanks again for all your work on this.  I think it will be a very popular
addition to Lucene.

---------------------------------------------------------------------
To unsubscribe, e-mail: lucene-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: lucene-dev-help@jakarta.apache.org


Mime
View raw message