Return-Path: Delivered-To: apmail-jakarta-lucene-dev-archive@www.apache.org Received: (qmail 82152 invoked from network); 1 Dec 2003 18:57:44 -0000 Received: from daedalus.apache.org (HELO mail.apache.org) (208.185.179.12) by minotaur-2.apache.org with SMTP; 1 Dec 2003 18:57:44 -0000 Received: (qmail 33630 invoked by uid 500); 1 Dec 2003 18:57:33 -0000 Delivered-To: apmail-jakarta-lucene-dev-archive@jakarta.apache.org Received: (qmail 33606 invoked by uid 500); 1 Dec 2003 18:57:33 -0000 Mailing-List: contact lucene-dev-help@jakarta.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Subscribe: List-Help: List-Post: List-Id: "Lucene Developers List" Reply-To: "Lucene Developers List" Delivered-To: mailing list lucene-dev@jakarta.apache.org Received: (qmail 33586 invoked from network); 1 Dec 2003 18:57:31 -0000 Received: from unknown (HELO mailer.syr.edu) (128.230.18.29) by daedalus.apache.org with SMTP; 1 Dec 2003 18:57:31 -0000 Received: from syr.edu (syru38-212.syr.edu) by mailer.syr.edu (LSMTP for Windows NT v1.1b) with SMTP id <0.0B38FE89@mailer.syr.edu>; Mon, 1 Dec 2003 13:57:28 -0500 Message-ID: <3FCB8F1B.3040009@syr.edu> Date: Mon, 01 Dec 2003 13:57:31 -0500 From: Steve Rowe User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.5) Gecko/20031007 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Lucene Developers List Subject: Re: cvs commit: jakarta-lucene/src/java/org/apache/lucene/analysis StopFilter.java References: <20031201182347.65354.qmail@minotaur.apache.org> <3FCB8B9C.1040809@syr.edu> <3FCB8D86.7010507@lucene.com> In-Reply-To: <3FCB8D86.7010507@lucene.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N You're right--sorry for the noise. - Steve Doug Cutting wrote: > Steve Rowe wrote: >> The line you removed is not dead code; the "position" variable (which >> IMNSHO should be named "positionIncrement" or something like it) needs >> to be reset to the default value. > > The 'position' variable is local to the method, not a field as in your > original patch. So it is automatically "reset" each time the method is > called, and need not be explicitly reset. > > Doug --------------------------------------------------------------------- To unsubscribe, e-mail: lucene-dev-unsubscribe@jakarta.apache.org For additional commands, e-mail: lucene-dev-help@jakarta.apache.org