lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jean-François Halleux <halleux...@skynet.be>
Subject RE: [Patch] Removing legacy Arrays class
Date Sun, 28 Dec 2003 19:14:31 GMT
java.util.Arrays was already used. (by DocumentWriter for example)

KR,

JFH

-----Original Message-----
From: Erik Hatcher [mailto:erik@ehatchersolutions.com]
Sent: dimanche 28 décembre 2003 18:08
To: Lucene Developers List
Subject: Re: [Patch] Removing legacy Arrays class


Jeff,

I have just removed the Arrays class - it was indeed unnecessary.
However, as I type this - I'm now concerned that I just broke the build
for 1.1 platforms (I don't know where we stand on JDK 1.1 compliance) -
although only broke it as far as the demo app is concerned.  The demo
app should not have strict 1.1 compliance - so that shouldn't be a
problem.

	Erik


On Dec 28, 2003, at 10:23 AM, Jean-François Halleux wrote:

> Hello,
>
> 	I think that the Arrays class in the Util package can be removed.
>
> The only file using it is IndexHTML in demo, for which a patch follows
> (includes a reorg of the imports as well)
>
> KR,
>
> Jeff Halleux
>
>
>
> Index: IndexHTML.java
> ===================================================================
> RCS file:
> /home/cvspublic/jakarta-lucene/src/demo/org/apache/lucene/demo/
> IndexHTML.jav
> a,v
> retrieving revision 1.1
> diff -u -r1.1 IndexHTML.java
> --- IndexHTML.java	26 Jan 2002 15:01:31 -0000	1.1
> +++ IndexHTML.java	28 Dec 2003 15:00:44 -0000
> @@ -54,14 +54,16 @@
>   * <http://www.apache.org/>.
>   */
>
> -import org.apache.lucene.analysis.standard.StandardAnalyzer;
> -import org.apache.lucene.index.*;
> -import org.apache.lucene.document.Document;
> -import org.apache.lucene.util.Arrays;
> -import org.apache.lucene.demo.html.HTMLParser;
> -
>  import java.io.File;
> +import java.util.Arrays;
>  import java.util.Date;
> +
> +import org.apache.lucene.analysis.standard.StandardAnalyzer;
> +import org.apache.lucene.document.Document;
> +import org.apache.lucene.index.IndexReader;
> +import org.apache.lucene.index.IndexWriter;
> +import org.apache.lucene.index.Term;
> +import org.apache.lucene.index.TermEnum;
>
>  class IndexHTML {
>    private static boolean deleting = false;	  // true during deletion
> pass
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: lucene-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: lucene-dev-help@jakarta.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: lucene-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: lucene-dev-help@jakarta.apache.org




---------------------------------------------------------------------
To unsubscribe, e-mail: lucene-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: lucene-dev-help@jakarta.apache.org


Mime
View raw message