Return-Path: Delivered-To: apmail-jakarta-lucene-dev-archive@www.apache.org Received: (qmail 70101 invoked from network); 25 Oct 2003 13:48:11 -0000 Received: from daedalus.apache.org (HELO mail.apache.org) (208.185.179.12) by minotaur-2.apache.org with SMTP; 25 Oct 2003 13:48:11 -0000 Received: (qmail 42523 invoked by uid 500); 25 Oct 2003 13:48:07 -0000 Delivered-To: apmail-jakarta-lucene-dev-archive@jakarta.apache.org Received: (qmail 42147 invoked by uid 500); 25 Oct 2003 13:48:04 -0000 Mailing-List: contact lucene-dev-help@jakarta.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Subscribe: List-Help: List-Post: List-Id: "Lucene Developers List" Reply-To: "Lucene Developers List" Delivered-To: mailing list lucene-dev@jakarta.apache.org Received: (qmail 42133 invoked from network); 25 Oct 2003 13:48:04 -0000 Received: from unknown (HELO moutng.kundenserver.de) (212.227.126.177) by daedalus.apache.org with SMTP; 25 Oct 2003 13:48:04 -0000 Received: from [212.227.126.206] (helo=mrelayng.kundenserver.de) by moutng.kundenserver.de with esmtp (Exim 3.35 #1) id 1ADOlx-0004VG-00 for lucene-dev@jakarta.apache.org; Sat, 25 Oct 2003 15:48:05 +0200 Received: from [62.245.161.100] (helo=detego-software.de) by mrelayng.kundenserver.de with asmtp (TLSv1:RC4-MD5:128) (Exim 3.35 #1) id 1ADOlx-0006N3-00 for lucene-dev@jakarta.apache.org; Sat, 25 Oct 2003 15:48:05 +0200 Message-ID: <3F9A7FD6.9090302@detego-software.de> Date: Sat, 25 Oct 2003 15:51:18 +0200 From: Christoph Goller User-Agent: Mozilla/5.0 (X11; U; Linux i686; de-AT; rv:1.4) Gecko/20030624 X-Accept-Language: de, en-us, en, de-at MIME-Version: 1.0 To: Lucene Developers List Subject: Re: subclassing of IndexReader References: <3F903C0C.8030209@lucene.com> In-Reply-To: <3F903C0C.8030209@lucene.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N Hi Doug, I reviewed your changes for subclassing of IndexReader and stumbled over the following: *)SegmentMerger.merge() now delivers the number of documents. Therefore, they don�t have to counted in IndexWriter.mergeSegments any longer. I changed this and all unit test still work including TestIndexWriter which tests exactly this number. So I think this small change is ok and I will commit it. *)I am just curious. What is IndexReader.undeleteAll needed for? *)SegmentsReader.undeleteAll does not set hasDeletions to false. I think this is a bug. Could you check please. *)The optimized implementation of SegmentTermDocs.seek(TermEnum enum) is essential in order to avoid unnecessary seek for termInfo in SegmentMerger.appendPostings(...). The problem I see is that SegmentTermDocs.seek(TermEnum enum) is public and there is no test to assure that enum is from the same segment as SegmentTermDocs. I think such a test should be added. If you agree, I can do that. Christoph --------------------------------------------------------------------- To unsubscribe, e-mail: lucene-dev-unsubscribe@jakarta.apache.org For additional commands, e-mail: lucene-dev-help@jakarta.apache.org