From lucene-dev-return-4291-apmail-jakarta-lucene-dev-archive=jakarta.apache.org@jakarta.apache.org Sun Oct 05 13:15:31 2003 Return-Path: Delivered-To: apmail-jakarta-lucene-dev-archive@www.apache.org Received: (qmail 130 invoked from network); 5 Oct 2003 13:15:30 -0000 Received: from daedalus.apache.org (HELO mail.apache.org) (208.185.179.12) by minotaur-2.apache.org with SMTP; 5 Oct 2003 13:15:30 -0000 Received: (qmail 64712 invoked by uid 500); 5 Oct 2003 13:15:25 -0000 Delivered-To: apmail-jakarta-lucene-dev-archive@jakarta.apache.org Received: (qmail 64685 invoked by uid 500); 5 Oct 2003 13:15:24 -0000 Mailing-List: contact lucene-dev-help@jakarta.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Subscribe: List-Help: List-Post: List-Id: "Lucene Developers List" Reply-To: "Lucene Developers List" Delivered-To: mailing list lucene-dev@jakarta.apache.org Received: (qmail 64671 invoked from network); 5 Oct 2003 13:15:24 -0000 Received: from unknown (HELO c000.snv.cp.net) (209.228.32.72) by daedalus.apache.org with SMTP; 5 Oct 2003 13:15:24 -0000 Received: (cpmta 431 invoked from network); 5 Oct 2003 06:15:25 -0700 Received: from 68.232.144.213 (HELO ehatchersolutions.com) by smtp.hatcher.net (209.228.32.72) with SMTP; 5 Oct 2003 06:15:25 -0700 X-Sent: 5 Oct 2003 13:15:25 GMT Date: Sun, 5 Oct 2003 09:15:24 -0400 Subject: Re: Please make org.apache.lucene.index.IndexWriter non-final Content-Type: text/plain; charset=US-ASCII; format=flowed Mime-Version: 1.0 (Apple Message framework v552) From: Erik Hatcher To: "Lucene Developers List" Content-Transfer-Encoding: 7bit In-Reply-To: <003b01c38b20$50f7fe70$2e81ba50@eamon> Message-Id: X-Mailer: Apple Mail (2.552) X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N Mike, I disagree with your request to change things just for testing purposes. There are ways to test most (if not all) of Lucene without having to affect method/class access levels. As big as I am into testing, I'm also big into using the right design for the right job. In the case of Lucene, 'final' is used liberally as well as other non-public access levels. Could you give us an example of what you're trying to test and how you're wishing you could go about it so that we could perhaps offer alternatives? Look at Lucene's current codebase. I've added a couple of mock objects recently to test various things - maybe that could give you some ideas? Erik On Sunday, October 5, 2003, at 05:09 AM, Mike Hogan wrote: > Hi, > > Please can you make org.apache.lucene.index.IndexWriter non-final. > It's > being final makes it impossible for me to test using mock objects. > Also, if > there are other public final classes that are significant to the > Lucene API, > please make them non-final also, for the same reason. > > One more thing, I see that there are cvs commits on the Lucene > project, but > no releases in a long while. What is the status with repect to new > releases? (In other words, if you do go ahead and make these classes > non-final, when can I expect to be able to make use of the changes :)). > > Thanks, > Mike. > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: lucene-dev-unsubscribe@jakarta.apache.org > For additional commands, e-mail: lucene-dev-help@jakarta.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: lucene-dev-unsubscribe@jakarta.apache.org For additional commands, e-mail: lucene-dev-help@jakarta.apache.org