lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Erik Hatcher <e...@ehatchersolutions.com>
Subject Re: New highlighter package available
Date Thu, 02 Oct 2003 23:07:37 GMT
Please, please please..... when you have substantial and important  
patches like this, use Bugzilla to enter them as an enhancement request  
and add cvs diff -u patch files as attachments to the issue.  E-mail  
(at least for me) is transient so makes it harder to go back to patches  
sent that way.

	Erik


On Thursday, October 2, 2003, at 03:00  PM, none none wrote:

> Hi Otis,
> as Tatu' explained (sorry i am pretty busy at work,  thank you Tatu'!)
> we only ask for "Support of Term Collector" and this needs some  
> changes in the core, changes are in a previous email i sent to the  
> list (can do it again), it is like a patch, doing that it will be  
> easier *for us* to provide highlight when a new version of Lucene  
> comes out.
> As for Mark works of the highlighter, it is not working with release  
> 1.3, due to big changes in the core, query rewrite, termenum, etc.
> As tatu said, there can be a waste of resource for users that do not  
> need term collector, so a boolean value will avoid that, by default we  
> can set it to TERM_COLLECTOR_OFF.
> I had to go through all the lucene code (almost) to make it work in  
> 1.3.
> that's all.
> thanks.
>
> Korfut.
>
> --
>
> --------- Original Message ---------
>
> DATE: Wed, 1 Oct 2003 17:26:51
> From: Otis Gospodnetic <otis_gospodnetic@yahoo.com>
> To: Lucene Developers List <lucene-dev@jakarta.apache.org>,  
> korfut@lycos.com
> Cc:
>
>> Korfut,
>>
>> I don't have the time to spend more time on this, but one thing is
>> confusing me here.  Mark provided a set of several classes that are
>> supposed to make hit highlighting possible.  I have not tested them,
>> but for certain reasons I believe the code works as advertized.
>>
>> Why does that code not work for you, that you need additional changes
>> to core Lucene to do hit highlighting?
>>
>> Thanks,
>> Otis
>>
>>
>>
>> --- none none <korfut@lycos.com> wrote:
>>> you know what my intention is, "highlighting support", as you said
>>> *enable*, i think we should rename this topic to "term collector"
>>> support, that is what it is necessary to provide from the core.
>>> Because you are right about highlighting, everyone has it's own
>>> implementation, i have a C module (dll) called by a JNI class to do
>>> highlight (performance reason).
>>> Hope to see approved this topic then :) , if so i can write down what
>>> it is necessary to do so, and i can provide a helper class to put in
>>> the sandbox.
>>> thank you,
>>> ciao Korfut.
>>> --
>>>
>>> --------- Original Message ---------
>>>
>>> DATE: Tue, 30 Sep 2003 16:33:15
>>> From: Scott Ganyo <scott.ganyo@etapestry.com>
>>> To: Lucene Developers List <lucene-dev@jakarta.apache.org>
>>> Cc:
>>>
>>>> Actually, I think anyone's informed opinion counts...
>>>>
>>>> Anyway, it's not that I don't like it.  I think it is a good thing
>>> to
>>>> support highlighting.  I just don't think it should be core
>>>> functionality as I believe that probably every project that uses
>>> Lucene
>>>> and wants to do highlighting will end up doing it in different ways.
>>>>
>>>> On the other hand, I agree with you that we should *enable*
>>> highlighting
>>>> in the core if necessary.  So, if there are changes that are
>>> globally
>>>> applicable to highlighting that would need to be made to the Lucene
>>>> core, we should definitely consider incorporating those changes.
>>>>
>>>> Scott
>>>>
>>>> none none wrote:
>>>>
>>>>> my opinion doesn't count at all! i know that...
>>>>> but personally i have been pushing for more than a year about
>>> highlighting support, i believe we should compromize a bit.
>>>>> my opinion is to keep the implementation outside the lucene core
>>> (as many of you don't like it, why??), BUT make the lucene core to
>>> support it :)
>>>>> If you guys want, i can send a document where i explain a few
>>> little change to do that (actually i did already: search mailing for
>>> hit collector, is a zip file).
>>>>> It is about make a few methods public and add a few arrays to
>>> collect terms and a boolean variable like the one in queryparser:
>>> DEFAULT_HIGHLIGHT with values SUPPORTED, NOT_SUPPORTED, not as
>>> default. This is necessary to enable/disable collection of terms when
>>> running a search (same some cpu/memory).
>>>>> My only reason is to avoid to keep up to date the code everytime
>>> there is a major release or critical updates, because it means to me
>>> go through the all code, then run some test cases to make sure it
>>> works properly. And from realease 1.2 to 1.3 was a nice challenge due
>>> to very big changes in the core.
>>>>> Thank you,
>>>>> bye.
>>>>> --
>>>>>
>>>>> --------- Original Message ---------
>>>>>
>>>>> DATE: Tue, 30 Sep 2003 14:44:00
>>>>> From: "Hani Suleiman" <hani@formicary.net>
>>>>> To: <lucene-dev@jakarta.apache.org>
>>>>> Cc:
>>>>>
>>>>>
>>>>>
>>>>>> Not that my vote counts or is relevant at all, but +1 to not
>>> including it,
>>>>>> for the same reasons below. Let Lucene focus on what it does best,
>>> and
>>>>>> ensure it can support addons and plugins like the highlighter,
>>> rather than
>>>>>> folding them in.
>>>>>>
>>>>>> Otis Gospodnetic said:
>>>>>>
>>>>>>
>>>>>>> Couldn't we also stick this in the Sandbox, make sure it builds
>>> into a
>>>>>>> nice little Jar, and just document it in the Lucene's xdocs?
>>>>>>> I'm just thinking that highlighting is not something that is
a
>>>>>>> necessary feature, so why 'polute' the core that should stay
lean
>>> as it
>>>>>>> is today.
>>>>>>> The same has been done with Snowball code.
>>>>>>>
>>>>>>> I don't feel VERY strongly about this, but I do feel that not
>>> including
>>>>>>> it in the core would be a better thing to do.  Those who need
it
>>> will
>>>>>>> know how to get the highlighting jar and put it in their
>>> CLASSPATH.
>>>>>>>
>>>>>>> Otis
>>>>>>>
>>>>>>>
>>>>>>> --- Erik Hatcher <erik@ehatchersolutions.com> wrote:
>>>>>>>
>>>>>>>
>>>>>>>> This looks great.
>>>>>>>>
>>>>>>>> Is everything cool licensing-wise with accepting this?  Is
it
>>> being
>>>>>>>> offered to us to be included?
>>>>>>>>
>>>>>>>> Just a quick glance at the code and the only thing I'd change
is
>>> the
>>>>>>>> default hilighting pre/post strings to be <b>/</b>,
or perhaps
>>> even
>>>>>>>> something even more general like <em>/</em> or
<span
>>>>>>>> class="hilighted">/</span> - but that is obviously
just icing.
>>>>>>>>
>>>>>>>> 	Erik
>>>>>>>>
>>>>>>>>
>>>>>>>> On Wednesday, September 24, 2003, at 05:56  PM, Doug Cutting
>>> wrote:
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>> Should this be added into the Lucene core?  I suspect
lots of
>>> folks
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> would like to use something like this.
>>>>>>>>>
>>>>>>>>> Doug
>>>>>>>>>
>>>>>>>>> markharw00d@yahoo.co.uk wrote:
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>> Details of a new highlighter package are available
here:
>>>>>>>>>> http://home.clara.net/markharwood/lucene/highlight.htm
>>>>>>>>>> Features include:
>>>>>>>>>> * Support for highlighting all query types
>>>>>>>>>> * Support for getting "best fragments" summary from
large docs
>>> *
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>> Works with latest version of Lucene
>>>>>>>>
>>>>>>>>
>>>>>>>>>> Hope you find this useful.
>>>>>>>>>> Mark Harwood
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>
>>>>>>> -----------------------------------------------------------------

>>>>>>> ----
>>>>>>>>
>>>>>>>>
>>>>>>>>> To unsubscribe, e-mail:
>>> lucene-dev-unsubscribe@jakarta.apache.org
>>>>>>>>>
>>>>>>>>>
>>>>>>>> For additional commands, e-mail:
>>> lucene-dev-help@jakarta.apache.org
>>>>>>>>
>>>>>>>>
>>>
>>>>>>> -----------------------------------------------------------------

>>>>>>> ----
>>>>>>>> To unsubscribe, e-mail:
>>> lucene-dev-unsubscribe@jakarta.apache.org For
>>>>>>>> additional commands, e-mail: lucene-dev-help@jakarta.apache.org
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>> __________________________________
>>>>>>> Do you Yahoo!?
>>>>>>> The New Yahoo! Shopping - with improved product search
>>>>>>> http://shopping.yahoo.com
>>>>>>>
>>>
>>>>>> ------------------------------------------------------------------

>>>>>> ---
>>> To
>>>>>>> unsubscribe, e-mail: lucene-dev-unsubscribe@jakarta.apache.org
>>>>>>> For additional commands, e-mail:
>>> lucene-dev-help@jakarta.apache.org
>>>>>>>
>>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>
>>>>> ------------------------------------------------------------------- 
>>>>> --
>>>>>> To unsubscribe, e-mail: lucene-dev-unsubscribe@jakarta.apache.org
>>>>>> For additional commands, e-mail:
>>> lucene-dev-help@jakarta.apache.org
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>>
>>>>> ____________________________________________________________
>>>>> Get advanced SPAM filtering on Webmail or POP Mail ... Get Lycos
>>> Mail!
>>>>> http://login.mail.lycos.com/r/referral?aid=27005
>>>>>
>>>
>>>> -------------------------------------------------------------------- 
>>>> -
>>>>> To unsubscribe, e-mail: lucene-dev-unsubscribe@jakarta.apache.org
>>>>> For additional commands, e-mail: lucene-dev-help@jakarta.apache.org
>>>>>
>>>>>
>>>>
>>>> -- 
>>>> All progress is initiated by challenging current conceptions, and
>>> executed by supplanting existing institutions. - George Bernard Shaw
>>>>
>>>>
>>>>
>>>
>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: lucene-dev-unsubscribe@jakarta.apache.org
>>>> For additional commands, e-mail: lucene-dev-help@jakarta.apache.org
>>>>
>>>>
>>>
>>>
>>>
>>> ____________________________________________________________
>>> Get advanced SPAM filtering on Webmail or POP Mail ... Get Lycos
>>> Mail!
>>> http://login.mail.lycos.com/r/referral?aid=27005
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: lucene-dev-unsubscribe@jakarta.apache.org
>>> For additional commands, e-mail: lucene-dev-help@jakarta.apache.org
>>>
>>
>>
>> __________________________________
>> Do you Yahoo!?
>> The New Yahoo! Shopping - with improved product search
>> http://shopping.yahoo.com
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: lucene-dev-unsubscribe@jakarta.apache.org
>> For additional commands, e-mail: lucene-dev-help@jakarta.apache.org
>>
>>
>
>
>
> ____________________________________________________________
> Get advanced SPAM filtering on Webmail or POP Mail ... Get Lycos Mail!
> http://login.mail.lycos.com/r/referral?aid=27005
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: lucene-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: lucene-dev-help@jakarta.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: lucene-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: lucene-dev-help@jakarta.apache.org


Mime
View raw message