Return-Path: 
 <lucene-dev-return-3543-qmlist-jakarta-archive-lucene-dev=nagoya.apache.org@jakarta.apache.org>
Delivered-To: apmail-jakarta-lucene-dev-archive@apache.org
Received: (qmail 21617 invoked from network); 12 May 2003 14:15:54 -0000
Received: from exchange.sun.com (192.18.33.10)
  by daedalus.apache.org with SMTP; 12 May 2003 14:15:54 -0000
Received: (qmail 4025 invoked by uid 97); 12 May 2003 14:17:59 -0000
Delivered-To: qmlist-jakarta-archive-lucene-dev@nagoya.betaversion.org
Received: (qmail 4018 invoked from network); 12 May 2003 14:17:59 -0000
Received: from daedalus.apache.org (HELO apache.org) (208.185.179.12)
  by nagoya.betaversion.org with SMTP; 12 May 2003 14:17:59 -0000
Received: (qmail 21373 invoked by uid 500); 12 May 2003 14:15:51 -0000
Mailing-List: contact lucene-dev-help@jakarta.apache.org; run by ezmlm
Precedence: bulk
List-Unsubscribe: <mailto:lucene-dev-unsubscribe@jakarta.apache.org>
List-Subscribe: <mailto:lucene-dev-subscribe@jakarta.apache.org>
List-Help: <mailto:lucene-dev-help@jakarta.apache.org>
List-Post: <mailto:lucene-dev@jakarta.apache.org>
List-Id: "Lucene Developers List" <lucene-dev.jakarta.apache.org>
Reply-To: "Lucene Developers List" <lucene-dev@jakarta.apache.org>
Delivered-To: mailing list lucene-dev@jakarta.apache.org
Received: (qmail 21362 invoked from network); 12 May 2003 14:15:51 -0000
Received: from mail2.atl.registeredsite.com (64.224.219.76)
  by daedalus.apache.org with SMTP; 12 May 2003 14:15:51 -0000
Received: from netmail.mail.registeredsite.com ([216.122.69.17])
	by mail2.atl.registeredsite.com (8.12.8/8.12.6) with ESMTP id h4CEFqhN020949
	(version=TLSv1/SSLv3 cipher=EDH-RSA-DES-CBC3-SHA bits=168 verify=NOT)
	for <lucene-dev@jakarta.apache.org>; Mon, 12 May 2003 10:15:53 -0400
Received: (qmail 42380 invoked by uid 89); 12 May 2003 14:16:13 -0000
Received: from unknown (HELO ehatchersolutions.com) (128.143.103.130)
  by 216.122.69.20 with SMTP; 12 May 2003 14:16:13 -0000
Date: Mon, 12 May 2003 10:15:52 -0400
Subject: Re: cvs commit: jakarta-lucene-sandbox/contributions/searchbean
 build.xml
Content-Type: text/plain; charset=US-ASCII; format=flowed
Mime-Version: 1.0 (Apple Message framework v552)
From: Erik Hatcher <lists@ehatchersolutions.com>
To: "Lucene Developers List" <lucene-dev@jakarta.apache.org>
Content-Transfer-Encoding: 7bit
In-Reply-To: <20030511205532.70869.qmail@icarus.apache.org>
Message-Id: <3CE09795-8484-11D7-BD2E-000393A564E6@ehatchersolutions.com>
X-Mailer: Apple Mail (2.552)
X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N
X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N

On Sunday, May 11, 2003, at 04:55  PM, otis@apache.org wrote:
> otis        2003/05/11 13:55:32
>
>   Modified:    contributions/searchbean build.xml
>   Log:
>   - Made the build look in the lib.dir property for *.jar files.

You said "property" here.  But ....

>        <pathelement location="${build.classes}"/>
>        <pathelement location="${build.test.classes}"/>
>        <pathelement location="."/>
>   -    <fileset dir="lib">
>   +    <fileset dir="lib.dir">

You should have used ${lib.dir} here, right?

>   +    <fileset dir="lib.dir">

And here.

>   +    <mkdir dir="lib.dir"/>

And here!  Why are you making a lib directory though?  Shouldn't the 
build presume its already there (I haven't looked at the details of 
this build file though - just a general comment).

	Erik


---------------------------------------------------------------------
To unsubscribe, e-mail: lucene-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: lucene-dev-help@jakarta.apache.org