lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Erik Hatcher <li...@ehatchersolutions.com>
Subject Re: cvs commit: jakarta-lucene-sandbox/contributions/searchbean build.xml
Date Mon, 12 May 2003 14:15:52 GMT
On Sunday, May 11, 2003, at 04:55  PM, otis@apache.org wrote:
> otis        2003/05/11 13:55:32
>
>   Modified:    contributions/searchbean build.xml
>   Log:
>   - Made the build look in the lib.dir property for *.jar files.

You said "property" here.  But ....

>        <pathelement location="${build.classes}"/>
>        <pathelement location="${build.test.classes}"/>
>        <pathelement location="."/>
>   -    <fileset dir="lib">
>   +    <fileset dir="lib.dir">

You should have used ${lib.dir} here, right?

>   +    <fileset dir="lib.dir">

And here.

>   +    <mkdir dir="lib.dir"/>

And here!  Why are you making a lib directory though?  Shouldn't the 
build presume its already there (I haven't looked at the details of 
this build file though - just a general comment).

	Erik


---------------------------------------------------------------------
To unsubscribe, e-mail: lucene-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: lucene-dev-help@jakarta.apache.org


Mime
View raw message